Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 08 Dec 2020 18:16:05 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 251688] mail/opendkim: Fix build with lua > 5.3
Message-ID:  <bug-251688-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251688

            Bug ID: 251688
           Summary: mail/opendkim: Fix build with lua > 5.3
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: dim@FreeBSD.org
                CC: freebsd-ports@dan.me.uk
                CC: freebsd-ports@dan.me.uk
             Flags: maintainer-feedback?(freebsd-ports@dan.me.uk)

Created attachment 220370
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D220370&action=
=3Dedit
Fix lua version check in mail/opendkim

Attempting to build mail/opendkim 2.10.3_11 with lua 5.4 installed (i.e. wi=
th
DEFAULT_VERSIONS+=3Dlua=3D5.4 in make.conf) leads to warnings and errors:

...
Making all in miltertest
cc -DHAVE_CONFIG_H -I. -I..  -I./../libopendkim -I/usr/include
-I/usr/local/include/lua54 -DCONFIG_BASE=3D\"/usr/local/etc\"  -O2 -pipe
-march=3Dhaswell  -fstack-protector-strong -fno-strict-aliasing -MT
miltertest-miltertest.o -MD -MP -MF .deps/miltertest-miltertest.Tpo -c -o
miltertest-miltertest.o `test -f 'miltertest.c' || echo './'`miltertest.c
miltertest.c:4016:2: warning: implicit declaration of function 'luaL_regist=
er'
is invalid in C99 [-Wimplicit-function-declaration]
        luaL_register(l, "mt", mt_library);
        ^
miltertest.c:4171:54: error: too few arguments to function call, expected 5,
have 4
                         script =3D=3D NULL ? "(stdin)" : script))
                                                            ^
/usr/local/include/lua54/lua.h:289:1: note: 'lua_load' declared here
LUA_API int   (lua_load) (lua_State *L, lua_Reader reader, void *dt,
^
/usr/local/include/lua54/luaconf.h:292:18: note: expanded from macro 'LUA_A=
PI'
#define LUA_API         extern
                        ^
1 warning and 1 error generated.
*** Error code 1

This is because ports r488837 changed the #if statements in this file, but
didn't use >=3D to check for any version of lua >=3D 5.2.

Attached patch will make it all work for a while, until lua messes up their=
 API
again.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-251688-7788>