From owner-freebsd-arch@FreeBSD.ORG Fri Jun 4 14:35:10 2004 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3557716A4CE for ; Fri, 4 Jun 2004 14:35:10 -0700 (PDT) Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id E119843D3F for ; Fri, 4 Jun 2004 14:35:09 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp2.server.rpi.edu (8.12.8/8.12.8) with ESMTP id i54LYEIX021037; Fri, 4 Jun 2004 17:34:15 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200406041933.i54JX9kj040764@mail.gits.dyndns.org> References: <200406041933.i54JX9kj040764@mail.gits.dyndns.org> Date: Fri, 4 Jun 2004 17:34:13 -0400 To: "Cyrille Lefevre" , From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) Subject: Re: Change to "kludge option processing" in /bin/ps X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2004 21:35:10 -0000 At 10:13 PM +0200 6/3/04, Cyrille Lefevre wrote: > >"Garance A Drosihn" wrote: >> At 5:08 PM +0200 5/31/04, Cyrille Lefevre wrote: >> > >> >before to commit new changes, think about how to fix the >> >following ones :) >> > >> ># ps -p ,, >> > PID TT STAT TIME COMMAND >> > 0 ?? ZW 0:00.00 (sshd) >> ># psx -p ,, >> >psx: no process id specified >> >> The above issue was pretty trivial to fix, and I have committed a > > change which should fix it. > >ok, let's try another issue : > ># ps -G " nobody " > PID TT STAT TIME COMMAND >75483 con- S 0:10.97 /usr/local/sbin/junkbuster configfile ># ps -G ,nobody, >ps: Invalid (zero-length) group name >ps: Invalid (zero-length) group name ># ps -G , >ps: Invalid (zero-length) group name >ps: Invalid (zero-length) group name frankly, polishing off the error-messages for INVALID input is not high on my list of priorities right now. It just isn't. And no, it would not be trivial to "just drop in" the massive update you had written (particularly when parts of it don't seem to work for me). From my point of view, I've gone more than a month without replies to email that I sent when I was eager to follow up on some of your work. Eventually I decided to just go ahead. I'm still interested, but not interested enough to throw out the updates I have been testing just so I can start over from scratch. >why do you make a difference while parsing commas and spaces ? What I have committed is an improvement from what was there. If there is a burning need to skip over blanks, then I'll be happy to write another one-or-two line update to allow that. But at the moment I am focusing on newsyslog, because there are a few users who are having some serious headaches due to limitations in newsyslog, and I believe it is more important for me to address those problems... Once I get my upcoming changes to newsyslog sorted out, then I will drop back to working on my upcoming changes to `ps'. Any other minor parsing issues will be fixed as time permits. I'm just a volunteer here, I am afraid I only have a little spare time that I can spend on freebsd. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu