From nobody Fri Jul 4 08:01:16 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bYR0X4c1Yz6163f; Fri, 04 Jul 2025 08:01:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bYR0X3wx3z3Dr3; Fri, 04 Jul 2025 08:01:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751616076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=htkNsi2gZkxAc/0NqEdEpIjRL/dwDs6HZrsQ+uGq4DA=; b=i2cLXZp4zCWI+YQrfz8KqL3DlqyL544EYBwmWnZsC+7OP1aZhW5HX7Vv8LQNDcN9PHkQf1 eCifbA60pKC08w5fp2RMRmo9+5AIOJNw4nh70mW5/qApaJnUagQos/0a/S0r/F9bJioPOk dbQnTW+CdzAP0Y4pB/sgURwxL3BrDHYpQq6QJEqgyrhqnvMCl2iBoUAZSWTsVkyWMbgK9H NzC3AbNQV8pBK6CFD38LNAkBIAu21IWusAQaAU00jyGRXwkAhBGjgyz4iVraFGfplbai9V uzkJ/U70UGtQBfKpXjTyRW4kgV/XneR8ZSTHCtzRSE9TKdgF2HNHIeZqQCJoAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751616076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=htkNsi2gZkxAc/0NqEdEpIjRL/dwDs6HZrsQ+uGq4DA=; b=ijEpkpsvqbpeWvH+ICmvsCh/yfKNjXQoVGJDKNV8EW83NGeUdpUdjbSZDakSjjW6CmKpCj tX2ld4l4z8ru3Puf9y16LfiCaHQphG0WFBjqRbven1YrZwYXGtbtL1kkzF3xw2XW7MJJ6l 7+9InWc2c0/jqClfjsmP23gFdqL5IZZ9z26LZI91gDV6hwWIyL5lxSTzt4FKUr8FQqCKnt dohWScxZ+Qi8cN4LvzzT26iwuOGM5TeEk7h288oikm+4x8a51/qV51b+L5VbBI58NYGAVu 5ex5lAkK6nELAZ/nVMbTywMnAg0jKLewtcFF25R2QEvrUNthMo1Nag09K9MkMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751616076; a=rsa-sha256; cv=none; b=pPK+t1ioOklOLRL0s7wXNUW96pItahzI6d2ZwfMygu0kYzYVu8mCJvkVZd32SsbZsY8Vqq PVKRBg5cecIra8O8gpqvmkTEBxwAXU1COtbj+M3776qZTX9SYvqQg2LXGU4sSa2zO6hc5b L7Z/iQonlzBzXvc2j4PYfUI7vpw5WQl94VrK5AlZF7Ee+x9nn+eYESPCZYE7qhLocLbDfd WjzsLi23nJLpLcsIwXW6e66EMquyZfSWCXshYarK8jNoWEa++UwrVY8VwEpz9aVKeitlIS Ee1RV6ciToHahKUMz9odqmrRe4OTNSG2SzhVLBLMp5hTNAEPzGdsZK5UQMiceA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bYR0X3TVCzj1R; Fri, 04 Jul 2025 08:01:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56481Gc0099605; Fri, 4 Jul 2025 08:01:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56481GQA099602; Fri, 4 Jul 2025 08:01:16 GMT (envelope-from git) Date: Fri, 4 Jul 2025 08:01:16 GMT Message-Id: <202507040801.56481GQA099602@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andriy Gapon Subject: git: ad0c3859a918 - main - mmc_da: garbage-collect sdda_get_max_data List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ad0c3859a9184036484c0cd63d7260a4a3d1ad2d Auto-Submitted: auto-generated The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=ad0c3859a9184036484c0cd63d7260a4a3d1ad2d commit ad0c3859a9184036484c0cd63d7260a4a3d1ad2d Author: Andriy Gapon AuthorDate: 2025-07-04 07:53:11 +0000 Commit: Andriy Gapon CommitDate: 2025-07-04 08:01:00 +0000 mmc_da: garbage-collect sdda_get_max_data The function is unused since 5aedb8b1d4a6. For information, in MMC CAM both XPT_GET_TRAN_SETTINGS and XPT_PATH_INQ obtain data using MMC_SIM_GET_TRAN_SETTINGS. So, "overlapping" information like ccb_trans_settings_mmc::host_max_data and ccb_pathinq::maxio is derived from the same source. That's why sdda_get_max_data was redundant. Reported by: bz MFC after: 5 days --- sys/cam/mmc/mmc_da.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/sys/cam/mmc/mmc_da.c b/sys/cam/mmc/mmc_da.c index 1c455e1951d7..9246f95a080e 100644 --- a/sys/cam/mmc/mmc_da.c +++ b/sys/cam/mmc/mmc_da.c @@ -1198,27 +1198,6 @@ sdda_get_host_caps(struct cam_periph *periph, union ccb *ccb) return (cts->host_caps); } -static uint32_t -sdda_get_max_data(struct cam_periph *periph, union ccb *ccb) -{ - struct ccb_trans_settings_mmc *cts; - - cts = &ccb->cts.proto_specific.mmc; - memset(cts, 0, sizeof(struct ccb_trans_settings_mmc)); - - ccb->ccb_h.func_code = XPT_GET_TRAN_SETTINGS; - ccb->ccb_h.flags = CAM_DIR_NONE; - ccb->ccb_h.retry_count = 0; - ccb->ccb_h.timeout = 100; - ccb->ccb_h.cbfcnp = NULL; - xpt_action(ccb); - - if (ccb->ccb_h.status != CAM_REQ_CMP) - panic("Cannot get host max data"); - KASSERT(cts->host_max_data != 0, ("host_max_data == 0?!")); - return (cts->host_max_data); -} - static void sdda_start_init(void *context, union ccb *start_ccb) {