Date: Thu, 05 Feb 2015 15:00:05 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197234] [UPDATE] lang/execline: update to 2.0.2.0 and take maintainership Message-ID: <bug-197234-13-iZ4Irp3B0S@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-197234-13@https.bugs.freebsd.org/bugzilla/> References: <bug-197234-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197234 --- Comment #5 from Jan Beich <jbeich@FreeBSD.org> --- (In reply to Colin Booth from comment #4) > (In reply to Jan Beich from comment #1) > >>> +LDFLAGS?=3D -s >>> +STRIPFLAGS?=3D -x > >>Better use ${STRIP} or depend on ! ${PORT_OPTIONS:MDEBUG} and maybe use v= endor `strip` make target e.g., > >> # STRIP can only be `-s` or empty >> ALL_TARGET=3D all ${STRIP:S/-s/strip/} > Adapted from the old Makefile for skalibs in ports. I'll yank those out b= ecause > it doesn't run strip by default anyway. Not stripping binaries at all would induce a warning: $ DEVELOPER=3D1 make ... =3D=3D=3D=3D> Running Q/A tests (stage-qa) Warning: 'bin/shift' is not stripped consider trying INSTALL_TARGET=3Dinstall-strip or using ${STRIP_CMD} Warning: 'bin/pipeline' is not stripped consider trying INSTALL_TARGET=3Dinstall-strip or using ${STRIP_CMD} ... >>> +USES=3D ${GMAKE} >>This works only by accident because the path to GNU make isn't an absolut= e one. > > That was on the suggestion of portlint since building execline (and skali= bs and > s6) don't work with the stock make and I'm working around a reasonably > linux-tools centric design. Many commands in Mk/bsd.commands.mk can be redefined by user or port maintainer. USES=3Dgmake is valid, but not USES=3D${GMAKE}. And portlint(1) is smarter = nowadays not to print some bogus warnings. > >>Define HAS_CONFIGURE and populate CONFIGURE_ARGS. This would also fix >> a case where CC contains spaces e.g., > Unless I'm reading the porters stuff wrong HAS_CONFIGURE only works with > autoconf and its ilk. Since skalibs et. al. don't use autotools I'm going= to > omit HAS_CONFIGURE (it seems to be ignored). However, that appears to mea= n that > I need the CC=3D${CC} definition which breaks if there's a multiple item = CC > definition. If I find out a better way to override this, I'll fix it. HAS_CONFIGURE is for generic configure-like scripts. It has no assumption a= bout GNU autoconf. Look for defined(HAS_CONFIGURE) in Mk/bsd.port.mk to see what exactly you'd get. To summarize, more environment variables passed by defau= lt, they're properly quoted Also check other ports with HAS_CONFIGURE e.g., lang/ocaml or lang/perl5.18. >>> + --prefix=3D${LOCALBASE} \ >>This would break install if PREFIX !=3D LOCALBASE i.e., poudriere >> testport -P. >You may need to pass --with-sysdeps as well to unbreak >> it. > Changed all LOCALBASE to PREFIX though that's still going to break if ska= libs > isn't going to be installed in the same root tree since execline needs to= find > the skalibs headers and I'm unaware of a good way of autodetecting that.= =20 LOCALBASE is where dependencies are already installed. PREFIX is where the current port is supposed to install. Before STAGEDIR support people used to check pkg-plist by overrding PREFIX to a temporary location. The following should be enough for LOCALBASE !=3D PREFIX support. # devel/skalibs CONFIGURE_ARGS=3D --prefix=3D${PREFIX} \ # lang/execline CONFIGURE_ARGS=3D --prefix=3D${PREFIX} \ --with-sysdeps=3D${LOCALBASE}/lib/skalibs/sysdeps \ --with-include=3D${LOCALBASE}/include \ --with-lib=3D${LOCALBASE}/lib/skalibs \ --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197234-13-iZ4Irp3B0S>