Date: Wed, 10 Oct 2007 20:34:09 +0300 From: Mike Makonnen <mtm@FreeBSD.Org> To: Dag-Erling Sm??rgrav <des@des.no> Cc: cvs-src@FreeBSD.org, Doug Barton <dougb@FreeBSD.org>, cvs-all@FreeBSD.org, obrien@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d early.sh Message-ID: <20071010173408.GA24022@terra.mike.lan> In-Reply-To: <86fy0jdn3y.fsf@ds4.des.no> References: <200710090730.l997UEEF042804@repoman.freebsd.org> <20071010002930.GA91077@dragon.NUXI.org> <86hckzgthr.fsf@ds4.des.no> <86fy0jdn3y.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 10, 2007 at 05:07:45PM +0200, Dag-Erling Sm??rgrav wrote: > Dag-Erling Sm??rgrav <des@des.no> writes: > > I must confess I don't really see the point of this change. Yes, people > > can write rc.d scripts instead, but not (by far) as easily as they can > > add a line or two to rc.early. > > > > If the problem is that rc.early is sourced by early.sh which is sourced > > by rc, simply rename early.sh to early so it runs in a subshell instead. > > Doug, any chance you can back out your change and apply to have > src/etc/rc.d/early.sh renamed to src/etc/rc.d/early instead? Whatever we end up doing just an FYI that the reason it's a .sh script is because it was sourced directly into the pre-rc.d /etc/rc. If we change it to be sourced in a sub-shell we will break rc.early scripts that define/modify environment variables that later scripts depend on. Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071010173408.GA24022>