Date: Mon, 26 Oct 2020 14:54:09 +0000 From: "Sergey A. Osokin" <osa@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r552869 - in head/www: . unit-python Message-ID: <20201026145409.GA27274@FreeBSD.org> In-Reply-To: <20201026120136.e2ocgipnntwxvim4@aching.in.mat.cc> References: <202010211554.09LFsMuJ075407@repo.freebsd.org> <20201026120136.e2ocgipnntwxvim4@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 26, 2020 at 01:01:36PM +0100, Mathieu Arnold wrote: > On Wed, Oct 21, 2020 at 03:54:22PM +0000, Sergey A. Osokin wrote: > > Author: osa > > Date: Wed Oct 21 15:54:22 2020 > > New Revision: 552869 > > URL: https://svnweb.freebsd.org/changeset/ports/552869 > > > > Log: > > Repo-copy www/py-unit to www/unit-python to be more consistent > > with the naming convention. > > Update www/unit-python to build with new name. > > Disconnect www/py-unit from the build. > > > > Added: > > head/www/unit-python/ > > - copied from r536987, head/www/py-unit/ > > Modified: > > head/www/Makefile > > head/www/unit-python/Makefile > > > > Modified: head/www/Makefile > > ============================================================================== > > --- head/www/Makefile Wed Oct 21 15:43:44 2020 (r552868) > > +++ head/www/Makefile Wed Oct 21 15:54:22 2020 (r552869) > > @@ -1722,7 +1722,6 @@ > > SUBDIR += py-turbogears2 > > SUBDIR += py-tvdb_api > > SUBDIR += py-txrequests > > - SUBDIR += py-unit > > SUBDIR += py-urlgrabber > > SUBDIR += py-urlman > > SUBDIR += py-urlobject > > @@ -2257,6 +2256,7 @@ > > SUBDIR += unit > > SUBDIR += unit-perl > > SUBDIR += unit-php > > + SUBDIR += unit-python > > SUBDIR += unit-ruby > > SUBDIR += uwebsockets > > SUBDIR += uwsgi > > > > Modified: head/www/unit-python/Makefile > > ============================================================================== > > --- head/www/py-unit/Makefile Fri May 29 18:36:38 2020 (r536987) > > +++ head/www/unit-python/Makefile Wed Oct 21 15:54:22 2020 (r552869) > > @@ -1,7 +1,7 @@ > > # Created by: Li-Wen Hsu <lwhsu@FreeBSD.org> > > # $FreeBSD$ > > > > -PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} > > +PKGNAMESUFFIX= -python${PYTHON_SUFFIX} > > This is wrong, the port should be called py-unit-python, and you should > be using: > > PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} > PKGNAMESUFFIX= -python Hey Mathieu, thanks for your input. I don't think we should use that naming convention in this particular case. So, let me try to explain my thoughts. NGINX Unit is the modern application server, it supports not only several different languages, such as go, java, javascript (Node.js), perl, php, python, ruby, but it also supports different versions of those languages. And I'm glad that FreeBSD is the first system that supports all the supported languages for NGINX Unit. It's possible to run NGINX Unit without those modules or with all of those modules, but not too much sense. On the other side, it's possible to conditionally split NGINX Unit components at least on two groups: a core component and application languages support. Follow that, the following ports have been created in FreeBSD ports tree: www/unit - core component of NGINX Unit and www/unit-[java|perl|php|python|ruby] family ports to support corresponding application languages. In terms of FreeBSD packages of NGINX Unit we may have: unit-java[8-15] for java language, unit-php[72|73|74|80rc2]-1.20.0 for php, unit-perl[5.28|5.30|5.32]-1.20.0 for perl, unit-python[3.6|3.7|3.8|3.9] for python, unit-ruby[2.5|2.6|2.7|3.0] for ruby, and that looks very clear for me, it's pretty streightforward naming convention: the application name, the supported language name, the supported language version. Historically, www/py-unit has been created by Li-Wen Hsu to support Python languages. But the port doesn't use the "py-" namespace at all. It's not a Python package, like other packages we have, but it uses Python version, just a number, and corresponding version of Python shared library to run a python application. Please let me know if you have any questions. Thank you. -- Sergey A. Osokin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201026145409.GA27274>