From owner-freebsd-current@FreeBSD.ORG Mon Jan 21 17:31:23 2013 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id EF100C32; Mon, 21 Jan 2013 17:31:23 +0000 (UTC) (envelope-from satan@ukr.net) Received: from hell.ukr.net (hell.ukr.net [212.42.67.68]) by mx1.freebsd.org (Postfix) with ESMTP id 6C8F7101; Mon, 21 Jan 2013 17:31:23 +0000 (UTC) Received: from satan by hell.ukr.net with local ID 1TxLDO-0005Kz-42 ; Mon, 21 Jan 2013 19:31:22 +0200 Date: Mon, 21 Jan 2013 19:31:22 +0200 From: Vitalij Satanivskij To: Jaakko Heinonen Subject: Re: panic after r244584 Message-ID: <20130121173122.GA20466@hell.ukr.net> References: <20130118073600.GA70874@hell.ukr.net> <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org> <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> <50F94D80.7000809@FreeBSD.org> <20130119082739.GA1956@a91-153-116-96.elisa-laajakaista.fi> <20130121154400.GA1808@a91-153-116-96.elisa-laajakaista.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130121154400.GA1808@a91-153-116-96.elisa-laajakaista.fi> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: satan@ukr.net, Alexander Motin , "Justin T. Gibbs" , Gleb Smirnoff , freebsd-current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2013 17:31:24 -0000 Jaakko Heinonen wrote: JH> On 2013-01-19, Jaakko Heinonen wrote: JH> > On 2013-01-18, Alexander Motin wrote: JH> > > At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are JH> > > impossible there, as previous name components are unique. Special JH> > > characters haven't yet seen, but I think theoretically possible. JH> > JH> > I see two possible solutions for the problem. JH> > JH> > 1) Replace non-printable, space and '/' characters for example with '_'. JH> > '/' should be replaced anyway. JH> > JH> > 2) Apply the patches in JH> > http://lists.freebsd.org/pipermail/svn-src-all/2013-January/063661.html JH> > to allow spaces again. I haven't committed the patches because I JH> > think that there isn't full consensus that it's right thing to do and JH> > also I personally prefer not to have spaces in device names. JH> JH> Here's a patch to implement 1: JH> JH> http://people.freebsd.org/~jh/patches/scsi_enc_ses-si_name.diff Ok that patch work's too. ses1: da0,pass5,probe8: Element descriptor: 'Slot 08' ses1: da0,pass5,probe8: SAS Device Slot Element: 1 Phys at Slot 7 ses1: phy 0: SATA device ses1: phy 0: parent 5003048000baa87f addr 5003048000baa853 da0 at mps0 bus 0 scbus7 target 8 lun 0 da0: Fixed Direct Access SCSI-6 device da0: 300.000MB/s transfers da0: Command Queueing enabled da0: 476940MB (976773168 512 byte sectors: 255H 63S/T 60801C)