From owner-cvs-all@FreeBSD.ORG Fri Dec 2 15:43:53 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D698106564A; Fri, 2 Dec 2011 15:43:53 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.49.45]) by mx1.freebsd.org (Postfix) with ESMTP id 236528FC19; Fri, 2 Dec 2011 15:43:52 +0000 (UTC) Received: by syn.atarininja.org (Postfix, from userid 1001) id 413C25C37; Fri, 2 Dec 2011 10:43:52 -0500 (EST) Date: Fri, 2 Dec 2011 10:43:52 -0500 From: Wesley Shields To: Michael Scheidell Message-ID: <20111202154352.GH56180@atarininja.org> References: <201111292239.pATMdtGq022326@repoman.freebsd.org> <20111202140059.GG56180@atarininja.org> <20B7E8C1930569419B93027F125DAB1506D1E214@USBCTDC001> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20B7E8C1930569419B93027F125DAB1506D1E214@USBCTDC001> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "'cvs-ports@FreeBSD.org'" , "'cvs-all@FreeBSD.org'" , "'ports-committers@FreeBSD.org'" Subject: Re: cvs commit: ports/security/fprint_demo Makefile distinfo pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2011 15:43:53 -0000 On Fri, Dec 02, 2011 at 02:16:32PM +0000, Michael Scheidell wrote: > -----Original Message----- > From: Wesley Shields [mailto:wxs@FreeBSD.org] > Sent: Friday, December 02, 2011 9:01 AM > To: Michael Scheidell > Cc: ports-committers@FreeBSD.org; cvs-ports@FreeBSD.org; cvs-all@FreeBSD.org > Subject: Re: cvs commit: ports/security/fprint_demo Makefile distinfo pkg-plist > > You didn't document this change in the commit log. :( > > I know.. had two of these, pam_fprint and this one. > > I thought I committed a BROKEN fprint_demo, and thought I was just > committing fixes. As a new committer you may not be familiar with the ways you can check your work before committing. I recommend using "cvs status" and being careful when checking what I'm committing. Ultimately, no major harm here so no foul. I'm just trying to be helpful to a new committer. :) > > | --- ports/security/fprint_demo/distinfo 2011/11/29 12:59:55 1.3 > > | +++ ports/security/fprint_demo/distinfo 2011/11/29 22:39:55 1.4 > > | @@ -1,2 +1,4 @@ > > | -SHA256 (fprint-demo_20080303+git.orig.tar.gz) = > > | fcff7f6e8d61b253b88dd87ecf5cdb5418ecf11178ce7cb6ae0e350485045232 > > | -SIZE (fprint-demo_20080303+git.orig.tar.gz) = 77714 > > | +SHA256 (fprint-demo_20080303git.orig.tar.gz) = > > | +fcff7f6e8d61b253b88dd87ecf5cdb5418ecf11178ce7cb6ae0e350485045232 > > | +SIZE (fprint-demo_20080303git.orig.tar.gz) = 77714 > > | +#http://mirrors.arsc.edu/ubuntu/packages/pool/ > > | +#universe/f/fprint-demo/fprint-demo_20080303git.orig.tar.gz > > Are these last two lines really meant to be there? > > Mostly to document that its in a STRANGE place (pam_fprint is in > _20080203+git) Not where I would put it. I'd put this information in the Makefile along with a comment explaining it. Again, no major harm and this is your port but the norm is to keep this information in Makefile and leave distinfo for recording size and checksums only. -- WXS