From owner-freebsd-testing@FreeBSD.ORG Thu May 1 22:44:35 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CC459FC4; Thu, 1 May 2014 22:44:35 +0000 (UTC) Received: from mailuogwdur.emc.com (mailuogwdur.emc.com [128.221.224.79]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mailuogwprd51.lss.emc.com", Issuer "RSA Corporate Server CA v2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 72FCF1651; Thu, 1 May 2014 22:44:34 +0000 (UTC) Received: from maildlpprd53.lss.emc.com (maildlpprd53.lss.emc.com [10.106.48.157]) by mailuogwprd51.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s41MiW9C001395 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 May 2014 18:44:32 -0400 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd51.lss.emc.com s41MiW9C001395 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=isilon.com; s=jan2013; t=1398984272; bh=G3CTpKOoVibsYp7KRCLr2pEs3vA=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-ID:Content-Transfer-Encoding:MIME-Version; b=chbr8WFvtq6KpBgPT8nQHbU0C+fYCLO63a/BuFVM0+/fc1sEqmvLIExBp96YAtH1b 4S+RwRRwaKEpb5kFbhIKPAW6X0TE+XfzhFP3/WI+YMnSaZNZXVP9CVlBynWndJS6RN Ik+MP+g6Lm7mMcjwpO59HI2e5T9i+5HsG0XbpQyM= X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd51.lss.emc.com s41MiW9C001395 Received: from mailusrhubprd53.lss.emc.com (mailusrhubprd53.lss.emc.com [10.106.48.18]) by maildlpprd53.lss.emc.com (RSA Interceptor); Thu, 1 May 2014 18:44:20 -0400 Received: from mxhub37.corp.emc.com (mxhub37.corp.emc.com [128.222.70.104]) by mailusrhubprd53.lss.emc.com (Sentrion-MTA-4.3.0/Sentrion-MTA-4.3.0) with ESMTP id s41MiKTj019587 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 1 May 2014 18:44:20 -0400 Received: from MXHUB104.corp.emc.com (10.253.58.16) by mxhub37.corp.emc.com (128.222.70.104) with Microsoft SMTP Server (TLS) id 8.3.327.1; Thu, 1 May 2014 18:44:20 -0400 Received: from MX103CL02.corp.emc.com ([169.254.6.21]) by MXHUB104.corp.emc.com ([::1]) with mapi id 14.03.0158.001; Thu, 1 May 2014 18:44:19 -0400 From: "Peel, Casey" To: Garrett Cooper Subject: Re: Please provide process for small, targeted fixes in tools/regression Thread-Topic: Please provide process for small, targeted fixes in tools/regression Thread-Index: Ac9VrITJRfNb0i8ZTXWISpxKRMnAiQALXaOAAAXxSeADsenUgAAvFKeA Date: Thu, 1 May 2014 22:44:19 +0000 Message-ID: References: <16437CC5729B5345AF77F816513376E820BAF854@MX103CL02.corp.emc.com> <5F1D5D49-5F39-4EAC-89D5-E4D10FB3B01E@freebsd.org> <16437CC5729B5345AF77F816513376E820BAFE8E@MX103CL02.corp.emc.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.1.140326 x-originating-ip: [10.13.52.90] Content-Type: text/plain; charset="us-ascii" Content-ID: <4055668E9E526143B031A14A3B06EEFF@mail.corp.emc.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Sentrion-Hostname: mailusrhubprd53.lss.emc.com Cc: "freebsd-testing@freebsd.org" , "bdrewery@FreeBSD.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 May 2014 22:44:35 -0000 > but out of curiosity why are you > removing the geom remove testing in the geom_mirror testcases? Does > the test not work out of the box on vanilla FreeBSD? To be honest, I haven't tested on a stock FreeBSD system, but on our internal almost-but-not-quite FreeBSD-CURRENT system removing the last partition of a gmirror fails. To remove the last partition you have to destroy the gmirror. It should be easy to confirm this is still true on FreeBSD-CURRENT. That said, I have the gmirror tests entirely moved over to ATF so I'm not sure its worth messing with. > These changes look ok. The only thing (just a consistency nit) is that > I would choose a consistent way of incrementing in loops, i.e. Good point, will do! -- Casey --=20 Performance Test Ninja casey.peel@isilon.com / 206.777.7945 On 4/30/14 10:16 AM, "Garrett Cooper" wrote: >On Fri, Apr 11, 2014 at 6:59 PM, Peel, Casey >wrote: >> Exellent, thanks Julio. >> >> Attached are 3 self-contained diffs, one per directory. Descriptions of >>the changes: >> * flock - .c changes to fix compiler errors; .t to wrap flock binary >>for integrating with prove >> * geom_mirror - gmirror won't let you remove the last partition in a >>mirror which all of these testcases do and thus fail (note that I've got >>these testcases plus other gmirror testcases already moved over to ATF >>and going through internal code reviews now, so maybe we just want to >>discard this) >> * kqueue - kqtest outputs files in TAP-consumable format, this is a .t >>file to run it through prove >> >> These were an intial salvo at getting existing tests working for our >>internal regression. I'm sure we'll be looking at others as well. If >>someone can just review the changes, I can get someone internally to >>commit them if necssary (although these will take more time to review >>than commit given how small they are). > > The test drivers seem ok for TAP, but out of curiosity why are you >removing the geom remove testing in the geom_mirror testcases? Does >the test not work out of the box on vanilla FreeBSD? >Thanks! >-Garrett >