From owner-cvs-src@FreeBSD.ORG  Fri Oct 31 09:42:23 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5C06F16A4CE; Fri, 31 Oct 2003 09:42:23 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 60C8D43FE0; Fri, 31 Oct 2003 09:42:20 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id EAA26513;
	Sat, 1 Nov 2003 04:42:17 +1100
Date: Sat, 1 Nov 2003 04:42:17 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Ruslan Ermilov <ru@freebsd.org>
In-Reply-To: <20031031163713.GA30874@sunbay.com>
Message-ID: <20031101043729.I1003@gamplex.bde.org>
References: <200310310542.h9V5gr8v023991@repoman.freebsd.org>
 <20031031230028.K1418@gamplex.bde.org> <20031031123129.GB777@sunbay.com>
 <20031101002134.Y1748@gamplex.bde.org> <20031031163713.GA30874@sunbay.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: Peter Wemm <peter@freebsd.org>
Subject: Re: cvs commit: src/sys/sys cdefs.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Oct 2003 17:42:23 -0000

On Fri, 31 Oct 2003, Ruslan Ermilov wrote:

> On Sat, Nov 01, 2003 at 12:34:51AM +1100, Bruce Evans wrote:
> > The system shouldn't have to satisfy cleanness standards of applications
> > that are not maintained by FreeBSD, especially when those standards
> > are bogus (e.g., compiling cleanly with -Wundef).  Hopefull all the
> > important corner cases in the system headers are tested by buildworld
> > so that we don't need to enlist the application maintainers to find bugs
> > in system headers.
> >
> Now that buildworld and normal builds behave the same, I tend to agree.
> Count this as "no objection" to revert this.

Thanks.

I think -Wsystem-headers needs to be set even when WARNS is not set (or
is 0) for world builds to actually be the same (if toplev.c doesn't set
it by default).  Then there would be another aspect of the old problem
that bsd.*.mk aren't entirely suitable for non-FreeBSD builds.

Bruce