From owner-freebsd-wireless@FreeBSD.ORG  Wed Mar  7 20:52:24 2012
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3901B1065674;
	Wed,  7 Mar 2012 20:52:24 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com
	[209.85.213.54])
	by mx1.freebsd.org (Postfix) with ESMTP id A88A08FC0A;
	Wed,  7 Mar 2012 20:52:23 +0000 (UTC)
Received: by yhgm50 with SMTP id m50so3679812yhg.13
	for <multiple recipients>; Wed, 07 Mar 2012 12:52:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:to:cc:reply-to:subject:in-reply-to:x-mailer
	:mime-version:content-type;
	bh=m44sS8yHZwgivinqVfYwfYUXa7dBhuSrS+CV3P2/p9Q=;
	b=I80PRiFUS24F4pIz/Z5IqQm1ZfkDqeIZqG5lZ5BJu0NSxxFrme51q5Yj04zdgwOpC3
	BOOFaiJYzXrKBMqCMk2ErfYpCtcqJowuKZZU7JjHA+z64v4GDU0H7almsXHx/0Y8ABtL
	ndw+9qI77XBrOJFseNfkAMqtim49PTu1+Jd3Vv/C4hZ2wQZhsuAnSOcXvzEz/+eL0aVf
	InqLe0Y5fJrrZfVbr4Gxipxlxpr7Rn04tKvdVDyM5zna+P6Sz1ZWuJoAjxn/a55zo6NF
	fC4onNEAhgKt4d0uz4TFZj8M/uHlEK+wDsqUlu8jN799Y+RipmCdt1DvODK3+nMCqGgu
	BE0Q==
Received: by 10.60.4.71 with SMTP id i7mr1481761oei.39.1331153543084;
	Wed, 07 Mar 2012 12:52:23 -0800 (PST)
Received: from www.palm.com ([32.175.144.149])
	by mx.google.com with ESMTPS id q5sm2879697oef.3.2012.03.07.12.52.16
	(version=SSLv3 cipher=OTHER); Wed, 07 Mar 2012 12:52:21 -0800 (PST)
Message-ID: <4f57ca85.05183c0a.7cf8.ffffb656@mx.google.com>
Date: Wed, 7 Mar 2012 12:52:19 -0800
From: "Adrian Chadd" <adrian.chadd@gmail.com>
To: "Bernhard Schmidt" <bschmidt@freebsd.org>, "Adrian Chadd"
	<adrian@freebsd.org>
In-Reply-To: <201203072118.47751.bschmidt@freebsd.org>
X-Mailer: Palm webOS v1.0.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>,
	Mitsuru IWASAKI <iwasaki@jp.freebsd.org>,
	"freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org>
Subject: Re: patches for if_iwi and wlan for WEP mode
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Adrian Chadd <adrian.chadd@gmail.com>
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Mar 2012 20:52:24 -0000

It's on topic because he included that in his patch. :)


Adrian



Sent from my Palm Pre on AT&amp;T
On Mar 7, 2012 12:18 PM, Bernhard Schmidt &lt;bschmidt@freebsd.org&gt; wrot=
e:=20

On Wednesday 07 March 2012 19:45:11 Adrian Chadd wrote:

&gt; Hi,

&gt;=20

&gt; I'd rather you didn't commit iwi_update_mcast() unless you absolutely

&gt; know that the NIC doesn't need to be notified of multicast group

&gt; membership changes. If so, please commit that as a separate fix.



Oh well, iwi(4) receives multicast frames just fine, they are

discarded somewhere else though last time I've checked, another

offtopic issue ;)



&gt; I'll look at iwi later and give you feedback on that particular change.



I did look into this once for ipw it was I guess, the firmware

doesn't support filtering based on addresses so everything one

could achieve here is enable/disable filtering of all multicast

frames. Check iwi_configuration.enable_multicast_filtering, which

is a bool actually not an uint8_t.



--=20

Bernhard