From owner-svn-ports-all@freebsd.org Tue Dec 26 11:06:30 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB462E859BE; Tue, 26 Dec 2017 11:06:30 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 990A97017B; Tue, 26 Dec 2017 11:06:30 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id AC88B1F17A; Tue, 26 Dec 2017 11:06:29 +0000 (UTC) Date: Tue, 26 Dec 2017 11:06:29 +0000 From: Alexey Dokuchaev To: "Carlos J. Puga Medina" Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r457244 - in head/multimedia/mpv: . files Message-ID: <20171226110629.GB99584@FreeBSD.org> References: <201712251800.vBPI0qS6007873@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201712251800.vBPI0qS6007873@repo.freebsd.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Dec 2017 11:06:30 -0000 On Mon, Dec 25, 2017 at 06:00:52PM +0000, Carlos J. Puga Medina wrote: > New Revision: 457244 > URL: https://svnweb.freebsd.org/changeset/ports/457244 > > Log: > multimedia/mpv: Add VAAPI on Wayland support > > - Add support to enable VAAPI under Wayland (disabled by default) > - Regenerate patch with makepatch to make portlint happy > > +.include > + > +.if ${PORT_OPTIONS:MVAAPI} && ${PORT_OPTIONS:MWAYLAND} > +CONFIGURE_ARGS+= --enable-vaapi-wayland > +LIB_DEPENDS+= libva-wayland.so:multimedia/libva > +.else > +CONFIGURE_ARGS+= --disable-vaapi-wayland > +.endif Consider using option helpers (shorter, more readable, declarative style, no .include needed): VAAPI_IMPLIES= WAYLAND VAAPI_LIB_DEPENDS= libva-wayland.so:multimedia/libva VAAPI_CONFIGURE_ENABLE= vaapi-wayland ./danfe