From nobody Tue Sep 27 12:20:58 2022 X-Original-To: doc@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4McJcq746Qz4crYb for ; Tue, 27 Sep 2022 12:20:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4McJcq661nz3LNB for ; Tue, 27 Sep 2022 12:20:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4McJcq57xjz16Jj for ; Tue, 27 Sep 2022 12:20:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 28RCKx8J031715 for ; Tue, 27 Sep 2022 12:20:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 28RCKxr4031705 for doc@FreeBSD.org; Tue, 27 Sep 2022 12:20:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: doc@FreeBSD.org Subject: [Bug 266571] Porter's Handbook: Using cargo: Use Makefile.crates instead of Makefile's CARGO_CRATES Date: Tue, 27 Sep 2022 12:20:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Documentation X-Bugzilla-Component: Books & Articles X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: doc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Documentation project List-Archive: https://lists.freebsd.org/archives/freebsd-doc List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-doc@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664281259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QYagOb5RE4++GpmQ+FXFRmmpUqwm7dWvHVaIbsoj7wI=; b=Q8tcKDbxBYFQTgeMn4DrE/S3+AW+VOZdoEXF/EX6+nSxoalh2qmKsg588e3zVtLsvEsfvi YGv3CER/dmkUcIUr1/ncDDXH9ic5KMKnYX351KhZYlbbgM7S/PvyEcou1Cj6jB1VYIsiid NdgA+MhDqV8ONO3zEvxEZomvpX7Pq6/3bQltvLa4xLvgSzJw+rVQ1VdM7E+z2ti0gJu8j4 7h48nGe8RBprKR54RJNukQX4Rr3AVsRMpYO3sDhyegfu4xNxRWoSN1fygdSc4feLTCTlhK wAXWehKdBzFEzIWwU+SWEhgl3mOOr8DndZLD3vjgIsd+j5IvMwJdxyoGPAG+bw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664281259; a=rsa-sha256; cv=none; b=JdIo/YOwZXdUm2FDBEnAOqX46L5zkmnsb6jd731G3yUyf7kBdJzOnLBfcUyKmBxF8KaWLP W/EumHp21p2FxsW9aRtc9DDeBFtpmPIih/WShaVhcDnDUpYmCdyxVOo5rQ4Jv44dcdPZNf HzjP4kpszwvcmzVUB6q5CenFpnYuOoIobvgCGzkdeOEDQK4ay5xYmAunULPZHiyaC0v5Mc D1rrrCq6TtCR31ebduCLmsog9aULZmmAYQ+Nxg+9oMDaxvf0o4snK3tmJMPNKuSKvguGo2 iLWmrn3f0vyXnDQcZzFrMmwQpBq1MRoxKZ5LqDP+aX5dV5+f8O/fq5MBJe1AUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266571 --- Comment #2 from Tobias Kortkamp --- My 2 cents: - Document Makefile.crates as a possible location but leave it up to the maintainer where to put CARGO_CRATES - It should be documented explicitly that CARGO_CRATES in Makefile is fine too. Don't make this a review issue plz. - Independent of where CARGO_CRATES is stored, updating it can be done automatically with cargo-crates-merge if portfmt is installed I feel like you don't gain anything by declaring that CARGO_CRATES must be in Makefile.crates instead of Makefile. What's needed is a technical USES=3Dcargo change along the lines of either - keep current approach but seed most of CARGO_CRATES from distinfo (since we currently have duplication of the same information for normal crates). Then most ports won't need to set CARGO_CRATES explicitly anywhere. - properly hook crates to the dependency graph as build inputs (as ports that do not create packages to allow reuse of their WRKSRC in USES=3Dcargo via something like BUILD_DEPENDS=3Drust-crates.io-libc>0:devel/rust-crates.io-libc:patch). Basically adopt a similar approach like GNU Guix cargo-build-system with the extra bonus of removing most of the duplicated crate versions we currently have (how many libc crate version do we really need???) and will allow us to deal with the many vulnerable crates in the tree in a comprehensive way just like normal dependencies. --=20 You are receiving this mail because: You are the assignee for the bug.=