From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 18 23:40:16 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 88BB21065675 for ; Mon, 18 Jun 2012 23:40:16 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5C5A48FC16 for ; Mon, 18 Jun 2012 23:40:16 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5INeGep026388 for ; Mon, 18 Jun 2012 23:40:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5INeGEQ026387; Mon, 18 Jun 2012 23:40:16 GMT (envelope-from gnats) Resent-Date: Mon, 18 Jun 2012 23:40:16 GMT Resent-Message-Id: <201206182340.q5INeGEQ026387@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jason Helfman Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C72251065673 for ; Mon, 18 Jun 2012 23:31:19 +0000 (UTC) (envelope-from jhelfman@experts-exchange.com) Received: from mail.dw.redsrci.com (mail.pub.dw.redsrci.com [72.29.183.251]) by mx1.freebsd.org (Postfix) with ESMTP id A76658FC21 for ; Mon, 18 Jun 2012 23:31:19 +0000 (UTC) Received: from mail.dw.redsrci.com (localhost [127.0.0.1]) by mail.dw.redsrci.com (Postfix) with ESMTP id A10886FD9EC; Mon, 18 Jun 2012 16:31:19 -0700 (PDT) Received: from mail.dw.redsrci.com ([127.0.0.1]) by mail.dw.redsrci.com (mail.dw.redsrci.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AXHkQ2RFrqN7; Mon, 18 Jun 2012 16:31:19 -0700 (PDT) Received: from experts-exchange.com (unknown [192.168.103.120]) by mail.dw.redsrci.com (Postfix) with SMTP id 7D1AD6FD98B; Mon, 18 Jun 2012 16:31:19 -0700 (PDT) Received: (nullmailer pid 76360 invoked by uid 1001); Mon, 18 Jun 2012 23:29:45 -0000 Message-Id: <1340062185.537242.76359.nullmailer@experts-exchange.com> Date: Mon, 18 Jun 2012 16:29:45 -0700 From: Jason Helfman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: admin@lissyara.su Subject: ports/169217: [PATCH] net/ttbudget: fix usage of ${SRC_BASE} before it is defined X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2012 23:40:16 -0000 >Number: 169217 >Category: ports >Synopsis: [PATCH] net/ttbudget: fix usage of ${SRC_BASE} before it is defined >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jun 18 23:40:15 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Jason Helfman >Release: FreeBSD 8.3-RELEASE amd64 >Organization: >Environment: System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr 9 21:23:18 UTC >Description: Original PR filed as ports/165994 SRC_BASE is being used before being defined in several ports. it happened to work anyways in most cases because the main use of SRC_BASE is for checking if ${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/. pet portlint on pkg-message and placement of USE_BZIP2 Port maintainer (admin@lissyara.su) is cc'd. Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS) >How-To-Repeat: >Fix: --- ttbudget-5.3_1.patch begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/net/ttbudget/Makefile,v retrieving revision 1.8 diff -u -r1.8 Makefile --- Makefile 1 Apr 2010 05:27:58 -0000 1.8 +++ Makefile 18 Jun 2012 23:30:31 -0000 @@ -17,6 +17,9 @@ COMMENT= Driver for 'TechnoTrend budget DVB S-1401' (SkyStar3) USE_BZIP2= yes + +.include + SYSDIR?= ${SRC_BASE}/sys KMODDIR= /boot/modules PLIST_SUB+= KMODDIR=${KMODDIR} @@ -32,8 +35,6 @@ post-install: @${CAT} ${PKGMESSAGE} -.include - .if ${ARCH} == "ia64" || ${ARCH} == "powerpc" || ${ARCH} == "sparc64" BROKEN= Does not compile on ia64, powerprc, or sparc64 .elif ${OSVERSION} >= 900000 Index: pkg-message =================================================================== RCS file: /home/pcvs/ports/net/ttbudget/pkg-message,v retrieving revision 1.1 diff -u -r1.1 pkg-message --- pkg-message 22 Jul 2008 18:10:19 -0000 1.1 +++ pkg-message 18 Jun 2012 23:30:31 -0000 @@ -11,5 +11,3 @@ to your /boot/loader.conf. ********************************************************************* - - --- ttbudget-5.3_1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: