Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Oct 2015 00:41:03 +0000 (UTC)
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r290126 - head/share/mk
Message-ID:  <201510290041.t9T0f3ZI079389@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bdrewery
Date: Thu Oct 29 00:41:03 2015
New Revision: 290126
URL: https://svnweb.freebsd.org/changeset/base/290126

Log:
  Fix regression from using .USEBEFORE in _SUBDIR in r289705.
  
  Using .USEBEFORE had the unintended side-effect of changing the directory for
  the real target ran in the current directory.  For example this meant that
  the 'make clean' would run in one of the SUBDIR.
  
  Sponsored by:	EMC / Isilon Storage Division
  Pointyhat to:	bdrewery

Modified:
  head/share/mk/bsd.subdir.mk

Modified: head/share/mk/bsd.subdir.mk
==============================================================================
--- head/share/mk/bsd.subdir.mk	Thu Oct 29 00:36:10 2015	(r290125)
+++ head/share/mk/bsd.subdir.mk	Thu Oct 29 00:41:03 2015	(r290126)
@@ -83,7 +83,7 @@ _SUBDIR_SH=	\
 _SUBDIR: .USEBEFORE
 .if defined(SUBDIR) && !empty(SUBDIR) && !defined(NO_SUBDIR)
 	@${_+_}target=${.TARGET:S,realinstall,install,}; \
-	    for dir in ${SUBDIR:N.WAIT}; do ${_SUBDIR_SH}; done
+	    for dir in ${SUBDIR:N.WAIT}; do ( ${_SUBDIR_SH} ); done
 .endif
 
 ${SUBDIR:N.WAIT}: .PHONY .MAKE



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201510290041.t9T0f3ZI079389>