From owner-cvs-all@FreeBSD.ORG Tue Aug 2 09:07:25 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D459716A41F; Tue, 2 Aug 2005 09:07:25 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3792D43D45; Tue, 2 Aug 2005 09:07:24 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j7297LeZ084204; Tue, 2 Aug 2005 12:07:21 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 02991-18; Tue, 2 Aug 2005 12:07:20 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j7297JVk084196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 2 Aug 2005 12:07:20 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.3/8.13.3) id j7297HdP060753; Tue, 2 Aug 2005 12:07:17 +0300 (EEST) (envelope-from ru) Date: Tue, 2 Aug 2005 12:07:17 +0300 From: Ruslan Ermilov To: Alexander Leidinger Message-ID: <20050802090717.GK14023@ip.net.ua> References: <200507292145.j6TLjkNc099549@repoman.freebsd.org> <86k6j8g7mq.fsf@xps.des.no> <20050730124053.507227dd@Magellan.Leidinger.net> <863bpvmnww.fsf@xps.des.no> <20050731102343.35bc4aa9@Magellan.Leidinger.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="enGqbSaueFq5omEL" Content-Disposition: inline In-Reply-To: <20050731102343.35bc4aa9@Magellan.Leidinger.net> User-Agent: Mutt/1.5.9i X-Virus-Scanned: by amavisd-new at ip.net.ua Cc: Dag-Erling Sm?rgrav , src-committers@FreeBSD.org, Peter Grehan , cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7 X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Aug 2005 09:07:26 -0000 --enGqbSaueFq5omEL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 31, 2005 at 10:23:43AM +0200, Alexander Leidinger wrote: > On Sun, 31 Jul 2005 09:31:59 +0200 > des@des.no (Dag-Erling Sm?rgrav) wrote: >=20 > > Alexander Leidinger writes: > > > What's more preferred, the use of ".error", or the way you solved it? > >=20 > > depends on what you think should happen if a user tries > >=20 > > # make installworld delete-old >=20 > Ok, point taken. >=20 > > BTW, I don't really see why {check,delete}-old-* should be restricted > > to native environments. DESTDIR might point to e.g. an NFS-exported > > filesystem from which thin clients of a different architecture boot. >=20 > Because of ObsoleteFiles.inc: > ---snip--- > .if ${MACHINE_ARCH} !=3D "alpha" && ${MACHINE_ARCH} !=3D "sparc64" > # 20040130: libkse renamed to libpthread > OLD_FILES+=3Dusr/lib/libkse.a > OLD_FILES+=3Dusr/lib/libkse.so > .endif > ---snip--- >=20 > We could change this to TARGET_ARCH instead, but then the user has to > set it, else he removes non-obsolete files. Even when we make it a > documented requirement, I don't have a good feeling regarding this. > There's too much foot-shooting potential if someone forgets to set it. > I think it's more user friendly / ergonomic to keep the current > restriction. With the restriction in place you need to have 2 > files (Makefile.inc1 and ObsoleteFiles.inc) or the NFS exported src > directory on one client to remove the old files. This is a little bit > more work, but forces the administrator to think a little bit about what > he does. It's part of my "as failsafe as possible" design of this > feature. >=20 > I don't object when someone wants to remove the restriction based upon > a decission of a majority (committers, user complains, whatever). >=20 TARGET_ARCH is always set in Makefile.inc1. It's set to MACHINE_ARCH by default. It should be safe to s/MACHINE_ARCH/TARGET_ARCH/ in ObsoleteFiles.inc and remove the condition for nativeness. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --enGqbSaueFq5omEL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFC7zfFqRfpzJluFF4RAjY1AJ9w8euHc++i7rpQsJlFDMSyjHsJsQCeP8uv wg+vYS2Dwd36TeTddOAWtes= =aniE -----END PGP SIGNATURE----- --enGqbSaueFq5omEL--