From nobody Tue Feb 10 17:56:09 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f9Tky1YZXz6Rj6w for ; Tue, 10 Feb 2026 17:56:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f9Tky0vhRz3fly for ; Tue, 10 Feb 2026 17:56:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770746170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Qzj4b6AEnBA58TgUbnox6fJUPpdiGf6T4VIPmWDSvXU=; b=c/0ayAP/nuP4U0O97ffXWWoYR9f1h3pq3kwNDMvRR9oJd6Efq3dFY4UjFK3+NbTUWlhIdH W3x4Ll0QkukvC7OgkC0SoiW/MgjbYWNPPX7HmB3b4qQog1DGTGZLYORLseQ1hRTvBdAwtZ kJupBQjUfFUuJS/kCiheTCukucY2toMYJzmJmeYt9bG8u+ZzHvGVQbzk8pGXkOaLdZuKrz e++TDj07n+b/H4fgSHFttRHgHZ6t6B3YhuEhVLQ7RSjhfa3bDNEPkgIHue3mXZkN2z2ShQ 0t/xPIMxGn+LawadtdepsJ3YToVyj/l7QoI7JaqP1MMoY0hjUNRvKv0fnurngw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770746170; a=rsa-sha256; cv=none; b=TgUiJlDbDCcfSyVk81H5eygNOhWdp1JyOMIcnJJE+TiGxBlzdUZawBbDu4dC22q5x1XPdr m1HkAmKfJs27FsAOTboXKps8d49+1oyduHpM2cVUIRqA1QMzO6e+DH66TFXrnLcO0lFWE1 LTd66691ePAm6lT3Woy514/vnsPnHNzzhX+asvOVICzoK6mIx9ceDo0YMm8SN8OZNJFW9j HPDsCBD5zZYNSJ9Teo8xNE5tYzu17XEh2WHoLjvfJGMItwO/iDvEJiNbZL7yTge+egvf+Z xnsrz57Y4EIt8BhVMmrgtRmfe+T43Ct8SfUouvxp3gcqIvgjxc3YJ0C51RQBSQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770746170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Qzj4b6AEnBA58TgUbnox6fJUPpdiGf6T4VIPmWDSvXU=; b=vDcXtz/LxiJiB0OHLMVV7lNMlq5L5AxzBlB7HJNsjMSHWQNh7DixgMPXT4e8lyz613G7Mk I8yITNl745x6gvTE1FwP+JSzHDFNP+T2RKi+4bnBEea1VTTCMVS1lif12fisRDKSdW/y+e wXGGTKbrBd71llk/KLRLvQWJ38Be4ZAFkXuV/O2EzyYNKqoRu1nZ6jF2za//Z88u9BXOXy COhVKgjkBlSI9BrVd/Zq+uTyPHLVcIDjkZY/EGfP4/swE+Oph63KITtouZPk+Pr8fX/28y UcmkSbagaDbdqzYsG0YPsH9MgNqbF26mT3+LdJCRbEXNjzQQhyVih1iMD1es2A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f9Tkx70nRz1RWx for ; Tue, 10 Feb 2026 17:56:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 268b9 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Feb 2026 17:56:09 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andy Carrel From: Mark Johnston Subject: git: 539bbdbd3b0c - releng/15.0 - arm64: Fix kernel panic in get_arm64_sve during core dump List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/15.0 X-Git-Reftype: branch X-Git-Commit: 539bbdbd3b0c3c235d441024cf28cef3afd6329e Auto-Submitted: auto-generated Date: Tue, 10 Feb 2026 17:56:09 +0000 Message-Id: <698b7139.268b9.860c0c0@gitrepo.freebsd.org> The branch releng/15.0 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=539bbdbd3b0c3c235d441024cf28cef3afd6329e commit 539bbdbd3b0c3c235d441024cf28cef3afd6329e Author: Andy Carrel AuthorDate: 2026-01-05 07:50:27 +0000 Commit: Mark Johnston CommitDate: 2026-02-09 16:39:50 +0000 arm64: Fix kernel panic in get_arm64_sve during core dump The coredump logic calls get_arm64_sve twice: once to get the note size, and once to get the data. The note size calculation depended on the volatile `PCB_FP_SVEVALID` flag. If this flag was cleared between the two calls (e.g., due to a context switch clearing the flag to comply with the ABI), the second call would expect a smaller buffer size than the first, triggering a KASSERT panic ("invalid size"). Fix this by ensuring the SVE state is saved to the PCB before we decide whether to use SVE or VFP. Approved by: so Security: FreeBSD-EN-26:04.arm64 PR: 292195 Reviewed by: andrew Differential Revision: https://reviews.freebsd.org/D54532 (cherry picked from commit 93d3ac1daa0ef3ac54ffcd5cc64a14638d04bd60) (cherry picked from commit c70a68bbdbf67e10a8cd8d46857cc6d4533096a9) --- sys/arm64/arm64/vfp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/arm64/arm64/vfp.c b/sys/arm64/arm64/vfp.c index bcddebfaf66e..64f13458e2d9 100644 --- a/sys/arm64/arm64/vfp.c +++ b/sys/arm64/arm64/vfp.c @@ -934,6 +934,9 @@ get_arm64_sve(struct regset *rs, struct thread *td, void *buf, pcb = td->td_pcb; + if (td == curthread && (pcb->pcb_fpflags & PCB_FP_STARTED) != 0) + vfp_save_state(td, pcb); + /* If there is no SVE support in HW then we don't support NT_ARM_SVE */ if (pcb->pcb_sve_len == 0) return (false); @@ -955,9 +958,6 @@ get_arm64_sve(struct regset *rs, struct thread *td, void *buf, KASSERT(*sizep == sizeof(struct svereg_header) + buf_size, ("%s: invalid size", __func__)); - if (td == curthread && (pcb->pcb_fpflags & PCB_FP_STARTED) != 0) - vfp_save_state(td, pcb); - header = buf; memset(header, 0, sizeof(*header));