Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Mar 2022 17:49:51 +0800
From:      Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        Cy Schubert <cy@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: 9bdc78861688 - main - sysutils/screen: Update to 4.9.0
Message-ID:  <CAMHz58QrJ0KsJhJDmUS%2B2DLbsKpxBMBKF7XRGam_G%2B=gJDmTTQ@mail.gmail.com>
In-Reply-To: <202203172344.22HNifI6099252@gitrepo.freebsd.org>
References:  <202203172344.22HNifI6099252@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000009000ac05da7b1350
Content-Type: text/plain; charset="UTF-8"

On Fri, Mar 18, 2022 at 7:44 AM Cy Schubert <cy@freebsd.org> wrote:

> The branch main has been updated by cy:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=9bdc788616889d0a2b3f9c8b8996610cdfe82be7
>
> commit 9bdc788616889d0a2b3f9c8b8996610cdfe82be7
> Author:     Cy Schubert <cy@FreeBSD.org>
> AuthorDate: 2022-03-17 17:54:50 +0000
> Commit:     Cy Schubert <cy@FreeBSD.org>
> CommitDate: 2022-03-17 23:44:10 +0000
>
>     sysutils/screen: Update to 4.9.0
>
>     Update screen to 4.9.0. From the release announcement:
>
>     New in this release:
>       * Hardstatus option for used encoding (escape string '%e')
>

Hi,

It seems the SHOWENC option is no longer needed.
And it breaks the build as follows:
===>  Building for screen-4.9.0
gmake[1]: Entering directory
'/usr/ports/works/usr/ports/sysutils/screen/work/screen-4.9.0'
CPP="cpp -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"'" srcdir=. sh
./osdef.sh
AWK=/usr/bin/awk CC="cc -O2 -pipe  -I/usr/include -DCOLORS256
-fstack-protector-strong -fno-strict-aliasing " srcdir=. sh ./comm.sh
AWK=/usr/bin/awk srcdir=. sh ./term.sh
sh ./tty.sh tty.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  putenv.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  kmapdef.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  term.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  comm.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  screen.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  ansi.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  fileio.c
cc -c -I. -I.  -DETCSCREENRC='"/usr/local/etc/screenrc"'
-DSCREENENCODINGS='"/usr/local/share/screen/utf8encodings"' -DHAVE_CONFIG_H
-DGIT_REV=\"\" \
     -O2 -pipe  -I/usr/include -DCOLORS256 -fstack-protector-strong
-fno-strict-aliasing  mark.c
screen.c:1215:5: warning: expression result unused [-Wunused-value]
    *--av;
    ^~~~~
screen.c:2789:10: error: duplicate case value '101'
    case 'e':
         ^
screen.c:2766:7: note: previous case defined here
        case 'e':
             ^
1 warning and 1 error generated.

Regards,
sunpoet

      * Fixes:
>         - fix combining char handling that could lead to a segfault
>         - CVE-2021-26937: possible denial of service via a crafted UTF-8
>           character sequence (bug #60030)
>         - make screen exit code be 0 when checking --help
>         - session names limit is 80 symbols (bug #61534)
>         - option -X ignores specified user in multiuser env (bug #37437)
>         - a lot of reformations/fixes/cleanups (man page and source code)
>
>     For full list of changes see
>     https://git.savannah.gnu.org/cgit/screen.git/log/?h=v.4.9.0
>
>     Note that CVE-2021-26937 was fixed in the FreeBSD port in 2021.

--0000000000009000ac05da7b1350
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Fri, Mar 18, 2022 at 7:44 AM Cy Schube=
rt &lt;<a href=3D"mailto:cy@freebsd.org">cy@freebsd.org</a>&gt; wrote:<br><=
/div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"=
margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-lef=
t:1ex">The branch main has been updated by cy:<br>
<br>
URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D9bdc788616889d0=
a2b3f9c8b8996610cdfe82be7" rel=3D"noreferrer" target=3D"_blank">https://cgi=
t.FreeBSD.org/ports/commit/?id=3D9bdc788616889d0a2b3f9c8b8996610cdfe82be7</=
a><br>
<br>
commit 9bdc788616889d0a2b3f9c8b8996610cdfe82be7<br>
Author:=C2=A0 =C2=A0 =C2=A0Cy Schubert &lt;cy@FreeBSD.org&gt;<br>
AuthorDate: 2022-03-17 17:54:50 +0000<br>
Commit:=C2=A0 =C2=A0 =C2=A0Cy Schubert &lt;cy@FreeBSD.org&gt;<br>
CommitDate: 2022-03-17 23:44:10 +0000<br>
<br>
=C2=A0 =C2=A0 sysutils/screen: Update to 4.9.0<br>
<br>
=C2=A0 =C2=A0 Update screen to 4.9.0. From the release announcement:<br>
<br>
=C2=A0 =C2=A0 New in this release:<br>
=C2=A0 =C2=A0 =C2=A0 * Hardstatus option for used encoding (escape string &=
#39;%e&#39;)<br></blockquote><div><br></div><div>Hi,</div><div><br></div><d=
iv>It seems the SHOWENC option is no longer needed.</div><div>And it breaks=
 the build as follows:</div>=3D=3D=3D&gt; =C2=A0Building for screen-4.9.0<b=
r>gmake[1]: Entering directory &#39;/usr/ports/works/usr/ports/sysutils/scr=
een/work/screen-4.9.0&#39;<br>CPP=3D&quot;cpp -DETCSCREENRC=3D&#39;&quot;/u=
sr/local/etc/screenrc&quot;&#39; -DSCREENENCODINGS=3D&#39;&quot;/usr/local/=
share/screen/utf8encodings&quot;&#39;&quot; srcdir=3D. sh ./osdef.sh<br>AWK=
=3D/usr/bin/awk CC=3D&quot;cc -O2 -pipe =C2=A0-I/usr/include -DCOLORS256 -f=
stack-protector-strong -fno-strict-aliasing &quot; srcdir=3D. sh ./comm.sh<=
br>AWK=3D/usr/bin/awk srcdir=3D. sh ./term.sh<br>sh ./tty.sh tty.c<br>cc -c=
 -I. -I. =C2=A0-DETCSCREENRC=3D&#39;&quot;/usr/local/etc/screenrc&quot;&#39=
; -DSCREENENCODINGS=3D&#39;&quot;/usr/local/share/screen/utf8encodings&quot=
;&#39; -DHAVE_CONFIG_H -DGIT_REV=3D\&quot;\&quot; \<br>=C2=A0 =C2=A0 =C2=A0=
-O2 -pipe =C2=A0-I/usr/include -DCOLORS256 -fstack-protector-strong -fno-st=
rict-aliasing =C2=A0putenv.c<br>cc -c -I. -I. =C2=A0-DETCSCREENRC=3D&#39;&q=
uot;/usr/local/etc/screenrc&quot;&#39; -DSCREENENCODINGS=3D&#39;&quot;/usr/=
local/share/screen/utf8encodings&quot;&#39; -DHAVE_CONFIG_H -DGIT_REV=3D\&q=
uot;\&quot; \<br>=C2=A0 =C2=A0 =C2=A0-O2 -pipe =C2=A0-I/usr/include -DCOLOR=
S256 -fstack-protector-strong -fno-strict-aliasing =C2=A0kmapdef.c<br>cc -c=
 -I. -I. =C2=A0-DETCSCREENRC=3D&#39;&quot;/usr/local/etc/screenrc&quot;&#39=
; -DSCREENENCODINGS=3D&#39;&quot;/usr/local/share/screen/utf8encodings&quot=
;&#39; -DHAVE_CONFIG_H -DGIT_REV=3D\&quot;\&quot; \<br>=C2=A0 =C2=A0 =C2=A0=
-O2 -pipe =C2=A0-I/usr/include -DCOLORS256 -fstack-protector-strong -fno-st=
rict-aliasing =C2=A0term.c<br>cc -c -I. -I. =C2=A0-DETCSCREENRC=3D&#39;&quo=
t;/usr/local/etc/screenrc&quot;&#39; -DSCREENENCODINGS=3D&#39;&quot;/usr/lo=
cal/share/screen/utf8encodings&quot;&#39; -DHAVE_CONFIG_H -DGIT_REV=3D\&quo=
t;\&quot; \<br>=C2=A0 =C2=A0 =C2=A0-O2 -pipe =C2=A0-I/usr/include -DCOLORS2=
56 -fstack-protector-strong -fno-strict-aliasing =C2=A0comm.c<br>cc -c -I. =
-I. =C2=A0-DETCSCREENRC=3D&#39;&quot;/usr/local/etc/screenrc&quot;&#39; -DS=
CREENENCODINGS=3D&#39;&quot;/usr/local/share/screen/utf8encodings&quot;&#39=
; -DHAVE_CONFIG_H -DGIT_REV=3D\&quot;\&quot; \<br>=C2=A0 =C2=A0 =C2=A0-O2 -=
pipe =C2=A0-I/usr/include -DCOLORS256 -fstack-protector-strong -fno-strict-=
aliasing =C2=A0screen.c<br>cc -c -I. -I. =C2=A0-DETCSCREENRC=3D&#39;&quot;/=
usr/local/etc/screenrc&quot;&#39; -DSCREENENCODINGS=3D&#39;&quot;/usr/local=
/share/screen/utf8encodings&quot;&#39; -DHAVE_CONFIG_H -DGIT_REV=3D\&quot;\=
&quot; \<br>=C2=A0 =C2=A0 =C2=A0-O2 -pipe =C2=A0-I/usr/include -DCOLORS256 =
-fstack-protector-strong -fno-strict-aliasing =C2=A0ansi.c<br>cc -c -I. -I.=
 =C2=A0-DETCSCREENRC=3D&#39;&quot;/usr/local/etc/screenrc&quot;&#39; -DSCRE=
ENENCODINGS=3D&#39;&quot;/usr/local/share/screen/utf8encodings&quot;&#39; -=
DHAVE_CONFIG_H -DGIT_REV=3D\&quot;\&quot; \<br>=C2=A0 =C2=A0 =C2=A0-O2 -pip=
e =C2=A0-I/usr/include -DCOLORS256 -fstack-protector-strong -fno-strict-ali=
asing =C2=A0fileio.c<br>cc -c -I. -I. =C2=A0-DETCSCREENRC=3D&#39;&quot;/usr=
/local/etc/screenrc&quot;&#39; -DSCREENENCODINGS=3D&#39;&quot;/usr/local/sh=
are/screen/utf8encodings&quot;&#39; -DHAVE_CONFIG_H -DGIT_REV=3D\&quot;\&qu=
ot; \<br>=C2=A0 =C2=A0 =C2=A0-O2 -pipe =C2=A0-I/usr/include -DCOLORS256 -fs=
tack-protector-strong -fno-strict-aliasing =C2=A0mark.c<br>screen.c:1215:5:=
 warning: expression result unused [-Wunused-value]<br>=C2=A0 =C2=A0 *--av;=
<br>=C2=A0 =C2=A0 ^~~~~<br>screen.c:2789:10: error: duplicate case value &#=
39;101&#39;<br>=C2=A0 =C2=A0 case &#39;e&#39;:<br>=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0^<br>screen.c:2766:7: note: previous case defined here<br>=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 case &#39;e&#39;:<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0^<br><div>1 warning and 1 error generated.</div><div><br><=
/div><div>Regards,</div><div>sunpoet</div><div><br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">
=C2=A0 =C2=A0 =C2=A0 * Fixes:<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - fix combining char handling that could lead t=
o a segfault<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - CVE-2021-26937: possible denial of service vi=
a a crafted UTF-8<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 character sequence (bug #60030)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - make screen exit code be 0 when checking --he=
lp<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - session names limit is 80 symbols (bug #61534=
)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - option -X ignores specified user in multiuser=
 env (bug #37437)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - a lot of reformations/fixes/cleanups (man pag=
e and source code)<br>
<br>
=C2=A0 =C2=A0 For full list of changes see<br>
=C2=A0 =C2=A0 <a href=3D"https://git.savannah.gnu.org/cgit/screen.git/log/?=
h=3Dv.4.9.0" rel=3D"noreferrer" target=3D"_blank">https://git.savannah.gnu.=
org/cgit/screen.git/log/?h=3Dv.4.9.0</a><br>
<br>
=C2=A0 =C2=A0 Note that CVE-2021-26937 was fixed in the FreeBSD port in 202=
1.</blockquote></div></div>

--0000000000009000ac05da7b1350--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58QrJ0KsJhJDmUS%2B2DLbsKpxBMBKF7XRGam_G%2B=gJDmTTQ>