From owner-cvs-all@FreeBSD.ORG Mon Jan 10 23:32:00 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B8A4516A4CE; Mon, 10 Jan 2005 23:32:00 +0000 (GMT) Received: from zaphod.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E9E143D1D; Mon, 10 Jan 2005 23:32:00 +0000 (GMT) (envelope-from simon@zaphod.nitro.dk) Received: by zaphod.nitro.dk (Postfix, from userid 3000) id 87B7911E13; Tue, 11 Jan 2005 00:31:58 +0100 (CET) Date: Tue, 11 Jan 2005 00:31:58 +0100 From: "Simon L. Nielsen" To: Scott Long Message-ID: <20050110233157.GJ777@zaphod.nitro.dk> References: <200501061745.j06Hj344034786@repoman.freebsd.org> <20050110184139.GE19624@funkthat.com> <20050110202344.GC777@zaphod.nitro.dk> <41E2E561.9000504@freebsd.org> <20050110205654.GF777@zaphod.nitro.dk> <41E2F4C6.1010000@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gmhhrsDozM2n+uz5" Content-Disposition: inline In-Reply-To: <41E2F4C6.1010000@freebsd.org> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: John-Mark Gurney cc: src-committers@freebsd.org cc: Maksim Yevmenkin cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netgraph ng_base.c src/sys/sys kernel.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2005 23:32:00 -0000 --gmhhrsDozM2n+uz5 Content-Type: multipart/mixed; boundary="UlsYxwg8UDQn+EKZ" Content-Disposition: inline --UlsYxwg8UDQn+EKZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2005.01.10 14:33:58 -0700, Scott Long wrote: > Well, I guess my point is that it's important to document exactly what > MODULE_DEPEND does do, and well as what it doesn't do. It's not really > a bug that it doesn't change SI_ORDER order, it's just a not a feature > that it was ever intended to support. A second paragraph under=20 OK. > DESCRIPTION that talks about this would probably be most appropriate. > Something like: >=20 > .Nm > provides hints to the kernel > .Xr loader 8 > and to > .Xr kldload 8 > to ensure that the named dependency is loaded prior to the existing=20 > module. It does not change or dictate the order in which modules are > initialized at runtime. OK, I just fixed a mdoc nit and changed kldload(8) to kernel linker (based on John-Mark Gurney's comment). The result is attached, which I plan to commit tomorrow unless somebody else has further refinements. --=20 Simon L. Nielsen --UlsYxwg8UDQn+EKZ Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="man-MODULE_DEPEND-bugs.2.patch" Index: MODULE_DEPEND.9 =================================================================== RCS file: /home/ncvs/src/share/man/man9/MODULE_DEPEND.9,v retrieving revision 1.6 diff -u -d -r1.6 MODULE_DEPEND.9 --- MODULE_DEPEND.9 7 Jan 2005 08:44:31 -0000 1.6 +++ MODULE_DEPEND.9 10 Jan 2005 23:20:10 -0000 @@ -28,7 +28,7 @@ .\" .\" $FreeBSD: src/share/man/man9/MODULE_DEPEND.9,v 1.6 2005/01/07 08:44:31 keramida Exp $ .\" -.Dd January 7, 2005 +.Dd January 11, 2005 .Dt MODULE_DEPEND 9 .Os .Sh NAME @@ -47,6 +47,15 @@ its version with .Fn MODULE_VERSION . .Pp +The +.Fn MODULE_DEPEND +macro provides hints to the kernel +.Xr loader 8 +and to the kernel linker to ensure that the named dependency is loaded +prior to the existing module. +It does not change or dictate the order in which modules are +initialized at runtime. +.Pp Three versions must be specified for .Fa moddepend : .Bl -tag -width ".Fa prefversion" --UlsYxwg8UDQn+EKZ-- --gmhhrsDozM2n+uz5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFB4xBth9pcDSc1mlERAoFeAJ4/LgVgXpebDqZGMLWYQppwEGkshACeO9gB Sp7AazIH6NcpwNKvu+FBl00= =laDF -----END PGP SIGNATURE----- --gmhhrsDozM2n+uz5--