From owner-freebsd-current@freebsd.org Sat Nov 7 18:56:19 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 48F48A29869 for ; Sat, 7 Nov 2015 18:56:19 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 2F3651639 for ; Sat, 7 Nov 2015 18:56:19 +0000 (UTC) (envelope-from marck@rinet.ru) Received: by mailman.ysv.freebsd.org (Postfix) id 2BBE1A29868; Sat, 7 Nov 2015 18:56:19 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2B5FCA29867 for ; Sat, 7 Nov 2015 18:56:19 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A97CE1638; Sat, 7 Nov 2015 18:56:18 +0000 (UTC) (envelope-from marck@rinet.ru) Received: from localhost (localhost [127.0.0.1]) by woozle.rinet.ru (8.14.5/8.14.5) with ESMTP id tA7IuCSA056180; Sat, 7 Nov 2015 21:56:12 +0300 (MSK) (envelope-from marck@rinet.ru) Date: Sat, 7 Nov 2015 21:56:12 +0300 (MSK) From: Dmitry Morozovsky To: Bryan Drewery cc: Garrett Cooper , gad@freebsd.org, current@freebsd.org Subject: Re: mtree patch for WITHOUT_LPR In-Reply-To: <563E4816.6030202@shatow.net> Message-ID: References: <563E2EB1.6030005@shatow.net> <563E4816.6030202@shatow.net> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-NCC-RegID: ru.rinet X-OpenPGP-Key-ID: 6B691B03 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (woozle.rinet.ru [0.0.0.0]); Sat, 07 Nov 2015 21:56:13 +0300 (MSK) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Nov 2015 18:56:19 -0000 On Sat, 7 Nov 2015, Bryan Drewery wrote: > >>> +/set type=dir uname=root gname=wheel mode=0755 > >>> +. > >>> + include > >>> + atf-c > >>> + .. > >>> + atf-c++ > >>> + .. > >> > >> This diff is incorrect. > > > > Yes, as Brian noted, this is completely orthogonal. > > > >> There are a lot of other things that need to be fixed if we go down this > >> path. Do you have a plan or idea of what all needs to be fixed? > > > > Well, I do not like the idea of tons of micro mtree files; OTOH, it would be > > great if we could avoid creation of unnecessary directories/files when > > particular WITHOU_* know is set. > > Another way of looking at this problem is that if a directory is in the > dist mtrees, it should not be listed as an OLD_DIRS. ... and this principle I do like much more, yes. It's no harm to have an empty subtree. Thank you! -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------