From owner-svn-src-head@freebsd.org Thu Jun 8 16:53:42 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0CE6EC0A4E8; Thu, 8 Jun 2017 16:53:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DC46A64B45; Thu, 8 Jun 2017 16:53:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id DFBBC10AFA3; Thu, 8 Jun 2017 12:53:32 -0400 (EDT) From: John Baldwin To: Justin Hibbits Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r319675 - in head/sys/compat/linuxkpi/common: include/linux src Date: Thu, 08 Jun 2017 09:46:03 -0700 Message-ID: <1791910.JUImbCqpWx@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <201706080244.v582iYTf034529@repo.freebsd.org> References: <201706080244.v582iYTf034529@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Thu, 08 Jun 2017 12:53:33 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 16:53:42 -0000 On Thursday, June 08, 2017 02:44:34 AM Justin Hibbits wrote: > Author: jhibbits > Date: Thu Jun 8 02:44:34 2017 > New Revision: 319675 > URL: https://svnweb.freebsd.org/changeset/base/319675 > > Log: > Remove ARM and MIPS from linuxkpi ioremap_attr definition > > ARM and MIPS fail universe builds. > > ARM and MIPS are missing the following: > * VM_MEMATTR_WRITE_THROUGH > * VM_MEMATTR_WRITE_COMBINING > > Pointy-hat to: jhibbits The intention when VM_MEMATTR_* was added was that they were macros on purpose so you could do things like: #ifdef VM_MEMATTR_WRITE_COMBINING /* WC is available as an option */ #endif Perhaps something similar can be done here? -- John Baldwin