Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Jan 2009 17:04:14 +0100 (CET)
From:      Matthias Andree <matthias.andree@gmx.de>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        question+fbsdports@closedsrc.org
Subject:   ports/131047: [PATCH] mail/getmail: fix excessive log volume
Message-ID:  <20090127160414.863F7B8B6@merlin.emma.line.org>
Resent-Message-ID: <200901271610.n0RGA22Y078427@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         131047
>Category:       ports
>Synopsis:       [PATCH] mail/getmail: fix excessive log volume
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 27 16:10:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Matthias Andree
>Release:        FreeBSD 7.1-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD merlin.emma.line.org 7.1-RELEASE-p2 FreeBSD 7.1-RELEASE-p2 #2: Wed Jan 14 17:14:29 CET 2009
>Description:
getmail 4.8.3 introduced a logging change that causes excessive (dozens of
megabytes per day) log growth by logging skipped messages in delete-after or
keep configurations.

The patch reverts to old behaviour, while leaving the opportunity for full
logging in verbose mode.

The patch has been submitted to the upstream maintainer as well, but I don't
expect a new getmail release soonish.

Added file(s):
- files/patch-excessive-logs

Port maintainer (question+fbsdports@closedsrc.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- getmail-4.8.4_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/mail/getmail/Makefile /usr/home/emma/ports/mail/getmail/Makefile
--- /usr/ports/mail/getmail/Makefile	2008-09-28 07:51:04.000000000 +0200
+++ /usr/home/emma/ports/mail/getmail/Makefile	2009-01-27 16:57:14.000000000 +0100
@@ -7,6 +7,7 @@
 
 PORTNAME=	getmail
 PORTVERSION=	4.8.4
+PORTREVISION=	1
 CATEGORIES=	mail python
 MASTER_SITES=	http://pyropus.ca/software/getmail/%SUBDIR%/ \
 		http://mirrors.closedsrc.org/getmail/
diff -ruN --exclude=CVS /usr/ports/mail/getmail/files/patch-excessive-logs /usr/home/emma/ports/mail/getmail/files/patch-excessive-logs
--- /usr/ports/mail/getmail/files/patch-excessive-logs	1970-01-01 01:00:00.000000000 +0100
+++ /usr/home/emma/ports/mail/getmail/files/patch-excessive-logs	2009-01-27 16:58:46.000000000 +0100
@@ -0,0 +1,17 @@
+--- getmail
++++ getmail
+@@ -210,10 +210,10 @@ def go(configs):
+ 
+                 if (retrieve or delete or oplevel > 1):
+                     log.info('  %s\n' % info)
+-                if options['logfile']:
+-                    options['logfile'].write(logline)
+-                if options['message_log_syslog']:
+-                    syslog.syslog(syslog.LOG_INFO, logline)
++                    if options['logfile']:
++                        options['logfile'].write(logline)
++                    if options['message_log_syslog']:
++                        syslog.syslog(syslog.LOG_INFO, logline)
+ 
+                 if (options['max_messages_per_session']
+                         and msgs_retrieved >=
--- getmail-4.8.4_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090127160414.863F7B8B6>