From owner-freebsd-hackers@FreeBSD.ORG Tue Mar 4 15:34:35 2008 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23758106566B; Tue, 4 Mar 2008 15:34:35 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id D95478FC13; Tue, 4 Mar 2008 15:34:34 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m24FXMx6071343; Tue, 4 Mar 2008 08:33:22 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 04 Mar 2008 08:33:50 -0700 (MST) Message-Id: <20080304.083350.1661915009.imp@bsdimp.com> To: rwatson@freebsd.org From: "M. Warner Losh" In-Reply-To: <20080304151326.J41184@fledge.watson.org> References: <20080303.224256.635730757.imp@bsdimp.com> <20080304151326.J41184@fledge.watson.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: hackers@freebsd.org Subject: Re: Comments on pmake diffs for building on Linux X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2008 15:34:35 -0000 In message: <20080304151326.J41184@fledge.watson.org> Robert Watson writes: : : On Mon, 3 Mar 2008, M. Warner Losh wrote: : : > --- pmake.orig/config.h 2005-02-01 03:50:35.000000000 -0700 : > +++ pmake/config.h 2008-03-03 22:24:16.745493000 -0700 : > @@ -108,4 +108,27 @@ : > # endif : > #endif : > : > +#ifndef TAILQ_HEAD_INITIALIZER : > +#define TAILQ_HEAD_INITIALIZER(head) { NULL, &(head).tqh_first } : > +#endif : : In most ports of FreeBSD parts to Linux that I've seen, the preferred solution : has to been to bring the entire FreeBSD queue.h with you rather than relying : on the native Linux queue.h. This is what we do for OpenBSM, for example; : this also helps out when you get to Mac OS X, Solaris, etc, where all the : queue.h's continue to vary in subtle ways. This depends a fair amount on a : lack of header pollution in the OS's own include files, of course... I was rather hoping for something that could be used without any of that nonsense... Warner