From owner-freebsd-hackers@FreeBSD.ORG Wed Mar 12 00:20:03 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B3A2E3D5 for ; Wed, 12 Mar 2014 00:20:03 +0000 (UTC) Received: from mail-pb0-f45.google.com (mail-pb0-f45.google.com [209.85.160.45]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 884AF875 for ; Wed, 12 Mar 2014 00:20:03 +0000 (UTC) Received: by mail-pb0-f45.google.com with SMTP id uo5so286177pbc.32 for ; Tue, 11 Mar 2014 17:20:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NMOQk+mUXWujgVO0FiwyQO4S7hXE6oy3maX+UE3MdZo=; b=VdXvloSmxC+/C08ZfzBXNEaFRjNfbHcP/uZa68pnJpDLzevAA25hY571hR0j2MCa56 ztry6BQBdrMw9bbMmfD47aGFAPxe6IRJ9zRscZwYubdkGlQNL8eILR8NNobakjcTBodr rYH7lkFNSwCxD+doX8tJhIoaVpWCE+0Aina0/qxppmWlieRiSa7gMTH80ON+X0RIVazs wKhWJ3yutCjjGvHf+vZCvJ7G7/Ut4YuguL/qj8Orc1iShyj/T06gg1SKZZQx9w2tNltF vcbtZ4b4buNzYh9NJQvAf+1kxzCWs9QPvztqxmIgDrXOsolFrwAoOHPwNkj4152aXwPF glLQ== X-Gm-Message-State: ALoCoQlzMS/VhrGwzZTuhBdGCiP/nsxiBvENhzcVnr6qLf16GzDlAKVJbk0ImMcbXcLh6JNSB4TG X-Received: by 10.68.11.199 with SMTP id s7mr1210521pbb.12.1394583603091; Tue, 11 Mar 2014 17:20:03 -0700 (PDT) Received: from cmeyer.west.isilon.com (c-67-182-131-225.hsd1.wa.comcast.net. [67.182.131.225]) by mx.google.com with ESMTPSA id jd5sm1276051pbb.18.2014.03.11.17.20.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Mar 2014 17:20:02 -0700 (PDT) From: Conrad Meyer To: freebsd-hackers@freebsd.org Subject: [PATCH 2/5] kern/vfs_syscalls.c: kern_readlinkat: Don't set return value to uninitialized value Date: Tue, 11 Mar 2014 17:19:40 -0700 Message-Id: <1394583583-19023-3-git-send-email-conrad.meyer@isilon.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1394583583-19023-1-git-send-email-conrad.meyer@isilon.com> References: <1394583583-19023-1-git-send-email-conrad.meyer@isilon.com> X-Mailman-Approved-At: Wed, 12 Mar 2014 02:09:50 +0000 Cc: Conrad Meyer , Jeffrey Roberson X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Mar 2014 00:20:03 -0000 Struct auio is only initialized in one branch, but we use it to set retval always. This isn't actually a problem because the other case is an error return, so the retval is discarded. However, fixing this reduces Clang static analysis pings, improving code smell. Signed-off-by: Conrad Meyer --- sys/kern/vfs_syscalls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index 4be9738..f680d43 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -2553,9 +2553,9 @@ kern_readlinkat(struct thread *td, int fd, char *path, enum uio_seg pathseg, auio.uio_td = td; auio.uio_resid = count; error = VOP_READLINK(vp, &auio, td->td_ucred); + td->td_retval[0] = count - auio.uio_resid; } vput(vp); - td->td_retval[0] = count - auio.uio_resid; return (error); } -- 1.8.5.3