From nobody Mon Sep 29 22:22:46 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cbG0X3nKLz68xJ4; Mon, 29 Sep 2025 22:22:52 +0000 (UTC) (envelope-from peterj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cbG0X3Dlgz3CD5; Mon, 29 Sep 2025 22:22:52 +0000 (UTC) (envelope-from peterj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759184572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4ZZ1CjOzD9hKq2bTpOLe94zxSUxi0Tsdf8QkdATVHK0=; b=o7610V57pFObbmxjIb5dYr4ctBD7rVDyRSRTMxKO8YOToVoV+82yQ/kNRUmMxEU7bF7m/w 4rDgSzgNT9QYAyCwZeMahMhJFK5j2sxwQUdJWQoEEQxWsbLIHBzoZXpCjoARHMCzZ9Chlf qb1EAomN48szYoGON2aEGkpgBIU8blsgl1BO/L4IsQezt8MwXG4LCjIbBAZqJMvQGgPAqo Ad7sAjT5ZZB7tkL24srJComVtg8LWZAtI4SSZN1k2Z7q6kkHOo9xjd4vsEJ+GmI9uy2LDu 0acO8qO0FaBWW0Ih6AvQmsCkNxYtMy1zpwoyKUBla6r4RPNjWVqIqaCBIAGh2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759184572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4ZZ1CjOzD9hKq2bTpOLe94zxSUxi0Tsdf8QkdATVHK0=; b=QYh84xFMwh0jjd4HW0PbqEdfpVnGwgHH4W/ZIcDrH8HJFPSdXwW8N+uVzK1TC7cYNsiMj3 WmN+fA4OTQC+sjMRShkQlni8q31xqr1VQ8IOAKbh2QtWo9MaqiSr+niT2ZPBB+Tv2kGCgr Ni4WNiiDH/9LNrtqXUBzi4GWibsQZcOgt3v4daUWda6F9t6TwdymDsCEJSYE1F0OCoFCP2 GVB5FofLq+tFlmmYiCZpo6BbamcEw5QXEFlxLjNQdiWK4Nu0Nhj0Ynsx1U3vNaHE9CP6PB L1SJWTRElq6ZNxHZuHh3L3/l5baDMB6EwwCl4TVa3YCvRhZTgowIQOE7HPmkCA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759184572; a=rsa-sha256; cv=none; b=gfsc2KADRWWwimat97SQw/CZj2PGACYLTE84Id0AJIOA3G2mZNa9p3C7rYrE1zhco9AAFT jbpY9AVKz20JNAo/1JTYiia4LN193YnEMl2qkhpt/nSeLYxqe2Xe8tyHfKjZJNkkEU7kvG z8JHNCmxDpBtbBFLMM5K8weE0E75Ok61mQADGOtUAVsEofDmuACkrM/E1WIwY3KCRRiLCe KK46bq3Gql3lhR3SPFMriOoxHK+D0Eyu9vif02qut0S9L3+7sZhrzI/z7JAJiS/tz/E0UQ 99lH1Zj21xUu9peH2ZR2iDE/5JZ09G32oIG1Q0eS7XvSABgl1QtJ8gxQaUfTcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from server.rulingia.com (ppp239-208.static.internode.on.net [59.167.239.208]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512) (Client did not present a certificate) (Authenticated sender: peterj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cbG0V5nL6zJnl; Mon, 29 Sep 2025 22:22:50 +0000 (UTC) (envelope-from peterj@freebsd.org) Date: Tue, 30 Sep 2025 08:22:46 +1000 From: Peter Jeremy To: Christos Margiolis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9cab9fde5eda - main - virtual_oss: Port to base Message-ID: References: <202509280958.58S9wrww083342@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="e/Z7ct8axfxIUQau" Content-Disposition: inline In-Reply-To: X-PGP-Key: http://www.rulingia.com/keys/peter.pgp --e/Z7ct8axfxIUQau Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2025-Sep-29 21:11:53 +0200, Christos Margiolis wr= ote: >On Mon Sep 29, 2025 at 11:58 AM CEST, Peter Jeremy wrote: >> On 2025-Sep-28 09:58:53 +0000, Christos Margiolis = wrote: >>>The branch main has been updated by christos: >>> >>>URL: https://cgit.FreeBSD.org/src/commit/?id=3D9cab9fde5edad9b409dd2317a= 2aec7815e6d6bed >>> >>>commit 9cab9fde5edad9b409dd2317a2aec7815e6d6bed >>>Author: Christos Margiolis >>>AuthorDate: 2025-09-28 09:56:52 +0000 >>>Commit: Christos Margiolis >>>CommitDate: 2025-09-28 09:56:52 +0000 >>> >>> virtual_oss: Port to base >> >> This fails to compile if "WITHOUT_BLUETOOTH=3Dyes" is specified (see bel= ow) >> because bluetooth.h isn't available (as expected). It looks like >> virtual_oss isn't taking that option into account when working out what >> to compile. =2E.. > >I haven't had time to test yet, but I will try tomorrow. Does the build >work if you build virtual_bt_speaker(8) conditionally in the Makefile >(i.e., usr.sbin/virtual_oss/Makefile)? The following patch builds as expected both with and without WITHOUT_BLUETOOTH=3Dyes diff --git a/usr.sbin/virtual_oss/Makefile b/usr.sbin/virtual_oss/Makefile index bf73041377b3..0fc611832795 100644 --- a/usr.sbin/virtual_oss/Makefile +++ b/usr.sbin/virtual_oss/Makefile @@ -1,8 +1,9 @@ .include =20 -SUBDIR+=3D virtual_bt_speaker \ - virtual_oss_cmd \ +SUBDIR+=3D virtual_oss_cmd \ virtual_oss =20 +SUBDIR.${MK_BLUETOOTH}+=3D virtual_bt_speaker=20 + .include "Makefile.inc" .include --=20 Peter Jeremy --e/Z7ct8axfxIUQau Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmjbBq5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzTR2Q//QdTQu9kSPOzQnkjwGsXawq4VG+ygz80WGLwkLa2rjUXFG/qYZjXEXy9V W+PE5Fp6xV93N7Kkxtfy5hn34N2NLLWFkZNonAGRySzKBRQ2jxivnClRm4VpsKLw sQhjL9cA8bVDBgxRoXwkloQKBDax0TdMMy3Qt1ZWGbJ5YcTwcJo6khK8X1q7dL6Y ZzGCKcLal+RYd6rjoKfih0ZaGnnLdvyX6IpwPEYSmDlAoWlo+CxnIF0+KWInYGEz Ip7Ij/UqX6UO9XDZ7adDxsG+qDeOAnjg867TbRvrUStD3EfrREAEtRjdtYHs529d ZCYQrkF40jaRUp63OgjadwGVVCgVBMzRGy99L/kXMqxQE9D2P5T7U8CLTQ89npyL 0rxb+eMPuhNuurXsXyE+Su9LFZd1OuMcRLBKBZ+nqHp66Mzgy4BKm3Pyl+BJXcLb 7vVF7d1H5hvpuHydGmNAkzOwL9ahcQnZm9NXD8VS7jq/G3/iRtrure20HB2OP1i2 MPNip7VwECjIgU8Ribp/BPcT4KKu4a8cqt8yCCGZwVNFWWjhd3N+ioT04W5Akyp8 e9f4AijDdmCSt8VJK7gADnL9wkgYWJSTzu3akEKAijXVnTYFBmI3+hKuI5zDpGu9 HJjP9s41KmVgWEY59uz9FxQvG7m9PsqRt0T0KP4xTwNK4xFoQBI= =P4z8 -----END PGP SIGNATURE----- --e/Z7ct8axfxIUQau--