From owner-cvs-all@FreeBSD.ORG Tue Feb 22 08:11:11 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E059A16A4CE; Tue, 22 Feb 2005 08:11:11 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0353543D2D; Tue, 22 Feb 2005 08:11:11 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j1M8B9nM044177; Tue, 22 Feb 2005 10:11:09 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 37788-07; Tue, 22 Feb 2005 10:11:08 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id j1M8B7f4044170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 22 Feb 2005 10:11:08 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id j1M8BFF2037109; Tue, 22 Feb 2005 10:11:15 +0200 (EET) (envelope-from ru) Date: Tue, 22 Feb 2005 10:11:14 +0200 From: Ruslan Ermilov To: Gleb Smirnoff Message-ID: <20050222081114.GA32753@ip.net.ua> References: <200502220739.j1M7dGGk012347@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <200502220739.j1M7dGGk012347@repoman.freebsd.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in_pcb.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Feb 2005 08:11:12 -0000 --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 22, 2005 at 07:39:15AM +0000, Gleb Smirnoff wrote: > glebius 2005-02-22 07:39:15 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/netinet in_pcb.c=20 > Log: > In in_pcbconnect_setup() remove a check that route points at > loopback interface. Nobody have explained me sense of this check. > It breaks connect() system call to a destination address which is > loopback routed (e.g. blackholed). > =20 > Reviewed by: silence on net@ > MFC after: 2 weeks > =20 > Revision Changes Path > 1.159 +2 -4 src/sys/netinet/in_pcb.c >=20 =46rom reading the code and Stevens TCP/IP Ill. (which doesn't make things more clear), I think the intent of this code was to select the "best" route such that an address selected could be routed over the network. But I don't think this is appropriate behavior and I like your change. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFCGukiqRfpzJluFF4RAucGAJ9WsE9OjX37VZHqb/TI6reAcKREOwCfbHe2 VO+Isbw+yLHqrz5q3XA790Q= =uGE7 -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--