From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue Jun 27 00:50:31 2006
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@hub.freebsd.org
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2A32E16A401
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Tue, 27 Jun 2006 00:50:31 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DAA2343D68
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Tue, 27 Jun 2006 00:50:17 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k5R0oHcS004032
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Tue, 27 Jun 2006 00:50:17 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k5R0oHRI004027;
	Tue, 27 Jun 2006 00:50:17 GMT (envelope-from gnats)
Resent-Date: Tue, 27 Jun 2006 00:50:17 GMT
Resent-Message-Id: <200606270050.k5R0oHRI004027@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Arseny Nasokin <tarc@tarc.po.cs.msu.su>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5EE4216A401
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 27 Jun 2006 00:49:37 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9D7D243D45
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue, 27 Jun 2006 00:49:24 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k5R0nO26087213
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 27 Jun 2006 00:49:24 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k5R0nOQb087212;
	Tue, 27 Jun 2006 00:49:24 GMT (envelope-from nobody)
Message-Id: <200606270049.k5R0nOQb087212@www.freebsd.org>
Date: Tue, 27 Jun 2006 00:49:24 GMT
From: Arseny Nasokin <tarc@tarc.po.cs.msu.su>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Cc: 
Subject: ports/99508: [PATCH][OPTIONS]audio/snd options fixes
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jun 2006 00:50:31 -0000


>Number:         99508
>Category:       ports
>Synopsis:       [PATCH][OPTIONS]audio/snd options fixes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 27 00:50:17 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     Arseny Nasokin
>Release:        FreeBSD 7.0-CURRENT
>Organization:
Moscow State University
>Environment:
>Description:
some missed options added and all checks moved to post section
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/snd/Makefile,v
retrieving revision 1.54
diff -d -u -r1.54 Makefile
--- Makefile    6 May 2006 01:28:19 -0000       1.54
+++ Makefile    27 Jun 2006 00:31:18 -0000
@@ -27,9 +27,13 @@
                CFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}"
 MAKEFILE=      makefile
 MAN1=          snd.1
-OPTIONS=       ESD             "output through enlightened sound daemon" on \
-               GUILE           "use Guile" on \
-               RUBY            "use Ruby as the extension language" on
+
+OPTIONS=       ESD             "output through enlightened sound daemon" on    \
+               GUILE           "use Guile" on                                  \
+               X11             "Build with GUI support"        on              \
+               RUBY            "use Ruby as the extension language" on         \
+               NLS             "Native Language Support"       on              
+
 PLIST=         ${WRKDIR}/plist
 PLIST_FILES=   share/examples/snd/DotEmacs
 PLIST_DIRS=    share/examples/snd
@@ -43,17 +47,22 @@
                share/doc/snd/tutorial/1_intro_and_build_snd.html~
 .endif

-.if defined(WITH_ESD)
+WANT_GNOME=yes
+USE_X_PREFIX=no
+
+.include <bsd.port.pre.mk>
+
+.if defined(WITH_ESD) || ! defined (WITHOUT_ESD)
 CONFIGURE_ARGS+=       --with-esd
 RUN_DEPENDS+=          esd:${PORTSDIR}/audio/esound
 .endif

-.if defined(WITH_RUBY)
+.if defined(WITH_RUBY) || ! defined (WITHOUT_RUBY)
 CONFIGURE_ARGS+=       --with-ruby
 RUN_DEPENDS+=          ruby:${PORTSDIR}/lang/ruby16
 .endif

-.if defined(WITH_GUILE)
+.if defined(WITH_GUILE) || !defined(WITHOUT_GUILE)
 LIB_DEPENDS+=          guile.15:${PORTSDIR}/lang/guile
 .if !defined(WITHOUT_X11)
 LIB_DEPENDS+=          guilegtk-1.2:${PORTSDIR}/x11-toolkits/guile-gtk
@@ -80,8 +89,6 @@
 USE_XLIB=      yes
 .endif

-.include <bsd.port.pre.mk>
-
 .if ${ARCH} == "sparc64"
 BROKEN=                does not compile on sparc64
 .endif
>Release-Note:
>Audit-Trail:
>Unformatted: