From owner-svn-src-all@FreeBSD.ORG  Tue Sep 21 16:17:38 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 380DA106564A;
	Tue, 21 Sep 2010 16:17:38 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com
	[209.85.216.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 6ED278FC24;
	Tue, 21 Sep 2010 16:17:37 +0000 (UTC)
Received: by qwg5 with SMTP id 5so4987246qwg.13
	for <multiple recipients>; Tue, 21 Sep 2010 09:17:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:sender:received
	:in-reply-to:references:date:x-google-sender-auth:message-id:subject
	:from:to:cc:content-type;
	bh=sEnPv864vnyqFtEdjtVgt2qesbm0VPQFARjdSqQu7Zg=;
	b=QqJ09GDNBEiy2xIRAZYdxmGa5mJyf0Th93Fgb0+CZoK+IiQoPrQp/2Xr6QWkHBrTsh
	HygBgOeGkdWmYBAqRB+beeAv79AOd1xTaRhwOCXacBCO7bRmi4mywlB3H+d+cydxiJz1
	gkihjYhvs6dZowZ5UjwTmxkCqHZdbW61MEMfI=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	b=hjKDsnFH/mSY02XAbGCSwnsmp1DI9U7Upzb/xcd8FPuNj6XEOJTd4IH/YygRDK5TJl
	yK4vnGg4LyKrtcYYuW3eifNYgtmEVr20eSGZnxmVHjodsxd5BVY3FF2mJg5yDu3GSLxi
	5QkXQsTC8R5EdvguIbWw4WLLz26R7jqqgO6pE=
MIME-Version: 1.0
Received: by 10.224.124.80 with SMTP id t16mr7178133qar.204.1285085856558;
	Tue, 21 Sep 2010 09:17:36 -0700 (PDT)
Sender: asmrookie@gmail.com
Received: by 10.229.235.143 with HTTP; Tue, 21 Sep 2010 09:17:36 -0700 (PDT)
In-Reply-To: <4C98D9FD.4050809@freebsd.org>
References: <201009211507.o8LF7iVv097676@svn.freebsd.org>
	<AANLkTi=CTr+ZDs3znsF-SXDp__xxbetjnhSBxiDhfFYy@mail.gmail.com>
	<4C98D9FD.4050809@freebsd.org>
Date: Tue, 21 Sep 2010 18:17:36 +0200
X-Google-Sender-Auth: Qw8BU2TFWbNAveweTT9p3jJPCQw
Message-ID: <AANLkTi=jSE00qffmHPMKSk-e+8sHYu6bxuo20vsxLgb2@mail.gmail.com>
From: Attilio Rao <attilio@freebsd.org>
To: Andriy Gapon <avg@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: svn-src-head@freebsd.org, mdf@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r212964 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Sep 2010 16:17:38 -0000

2010/9/21 Andriy Gapon <avg@freebsd.org>:
> on 21/09/2010 18:17 mdf@FreeBSD.org said the following:
>> I'd recommend using stack_print_ddb(), as that avoids any locking
>> which may hang depending on how the kernel panic'd.
>
> How does the following look to you?
> I hope I haven't freed too much from under DDB.
> The patch compiles fine with STACK && !DDB.

In general, if you really want to go with that route, I'd rename the
functions with _unlocked() prefix (there is actually no need to tell
they are _ddb specific) and maybe add _ddb() wrappers, you can have
more opinions.

Thanks,
Attilio


-- 
Peace can only be achieved by understanding - A. Einstein