From owner-freebsd-current@FreeBSD.ORG Wed May 20 14:56:29 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CE927B69 for ; Wed, 20 May 2015 14:56:29 +0000 (UTC) Received: from mail-ig0-x236.google.com (mail-ig0-x236.google.com [IPv6:2607:f8b0:4001:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 977D31372 for ; Wed, 20 May 2015 14:56:29 +0000 (UTC) Received: by igcau1 with SMTP id au1so41624668igc.1 for ; Wed, 20 May 2015 07:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=vtsYTZYBRUzymGxVfLlUlrIvHX2h47X976l1s74MSM4=; b=Mu1Zu1wkd0uppTo/vawNgVd+YfKrmjWetI1vjXTT+xoZinimIE1/YBDWrkLmOJAb/t y0gaoP4WAidDEiiYHtvdIM37BXfH3Eyop2PXFZXRTh7XxDXn4m6pD9nyUvh/eziNnaNL S33R00RxFdN4vpkDzSG7G2si3d+KETbztxsPFp/Gd2GgZZXD9O7YWzAfAA3+Jo+UplNj 1PFUL/WlOzObJdgZbflrldWKhhCqW1fOldcOQAGkWC+Lzm5gun2TX8vhImNyYx4t3riM V/b9n8VNYRJHp2MFOgJqDkxU7W6iGkO0jFmCdwt27K2hRr24VlOgoURZxMh5v0Anfbz0 P/aw== MIME-Version: 1.0 X-Received: by 10.50.141.198 with SMTP id rq6mr28370235igb.6.1432133789087; Wed, 20 May 2015 07:56:29 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.38.133 with HTTP; Wed, 20 May 2015 07:56:29 -0700 (PDT) In-Reply-To: <20150520075030.GJ2499@kib.kiev.ua> References: <20150520075030.GJ2499@kib.kiev.ua> Date: Wed, 20 May 2015 07:56:29 -0700 X-Google-Sender-Auth: NC896ObNvZBBe0Ipo4UGQ9O3tss Message-ID: Subject: Re: libc/gen: unused variables From: Adrian Chadd To: Konstantin Belousov Cc: freebsd-current Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2015 14:56:29 -0000 On 20 May 2015 at 00:50, Konstantin Belousov wrote: > On Wed, May 20, 2015 at 12:11:08AM -0700, Adrian Chadd wrote: >> Hi, >> >> here's a patch against -head that eliminates gcc-4.9 complaining about >> set-but-unused variables. It just comments them out for now - are >> these okay to eliminate, or is there something else that's >> broken/missing? > Of course, the patch as posted must not be committed. Absolutely. This patch was more like "is this all dead code, or are we supposed to be checking these fields and we aren't?" > For dl_init_phdr_info(), it is acceptable to eliminate AT_PHENT case > and phent local. Would you like to do the elimination, so I don't mess it up? :) > I have not looked at the other places. Thanks though! -adrian