From nobody Thu Mar 5 19:07:35 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fRfDl4tNvz6TWPD for ; Thu, 05 Mar 2026 19:07:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fRfDl3pYWz44LK for ; Thu, 05 Mar 2026 19:07:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772737655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a7z+1dAlMU/+hud3WY7Ks0L9852uQB7xkg6e3XkdlAA=; b=Ay6UxZWaeBVuKHS2Pg35rEE9G3VkqT2+C+tihBvD0etktwOij+5+GclHZP4YvFidMq1xMd BgVZEM+/qwFU9KY8FC1opwHUc3SLxNG3ey+u1tWMUv5ZSo7cLNmu9LuVQQ2QG1VdG32GYV yM7VYDtaPSWEIr32f9kvf/G3PI7PkVRSBy8PQ4L4WgOCNpFFj0Fk3S3qPGVWKsUzKW17T8 YBWmHKM+dJBRuWW+UMSbQCivkiMejspQzHz6MJNoj/AowoYdrPgl6Fwbwe9mXyBHtyOiSL et8cTQWRaKzy97Hm/Q8BFn7rspJqf6HTl4TW0bJKtHEPl0LzWnilYBNAbI1jmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772737655; a=rsa-sha256; cv=none; b=pdf++gwQQBq2xaz8Oj15Yl/uVs2mMmLSSrZqtwzkcsA8c2NvDtDCfRaE77OYLspzAYKRTJ Tdzao4IALeaXuduwTOUUzm4nHJU5tgoNa2k955uGz59yOQItQ3dJjEP9f12OTeY5XosmUu lAxiiqqUlm3aJkjOS2eNCC+hIyR9da42B1JPkCWUrZ1205ymuypphCFUelmmGPvWmEBbSP tnp8ViNQFv/YdXxLlWLfABXn79HtFshfDAKmz5NoAd5ijwOY9LPL2paf3K7FNG5brehsjP mjdSI+wIIvn649OkQnlCAEBUopk7J3iAki925bv8mS9RsYtkUWY2YoaDCz8yRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772737655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a7z+1dAlMU/+hud3WY7Ks0L9852uQB7xkg6e3XkdlAA=; b=YVQioKZg0wsCWOdabjNXiHn3kn9waECX5mwup0O86/mJA/GqtRrnGkh4ET3eTHY4P6FQoV BDqNYgXRMuGNNWEcpnskAOg3cbTS3YvRyCm86VVC3jSPOaBTZFEa6eDbHnf5ZRQkiYSzip iOcH4z44G+v0Xsi+5HNj4sYqZ69Kuo2C7gX/HbbiQJwCHgGtTb42PEBONYYbnffl65n0iC 78n+3XincFuJU/KsY5TnhkMaz8F1SBB4GqgdZ7MwOH7a3RwMAnEU/3CdPpINl5mGjZ1193 r5rw6Dd6jBKexKrSMNEpD86/ZMxpftkY8Vh7UFlv9ZIx+VbCesFsewa5VSTkbg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fRfDl3DWRzqTv for ; Thu, 05 Mar 2026 19:07:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 47dfc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 05 Mar 2026 19:07:35 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: d19f2af2b7f9 - main - acpi: Don't attach a "wake" sysctl node to devices without the ACPI flags IVAR List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d19f2af2b7f9c964622fd2eba7d077c6f221b652 Auto-Submitted: auto-generated Date: Thu, 05 Mar 2026 19:07:35 +0000 Message-Id: <69a9d477.47dfc.2269a454@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=d19f2af2b7f9c964622fd2eba7d077c6f221b652 commit d19f2af2b7f9c964622fd2eba7d077c6f221b652 Author: John Baldwin AuthorDate: 2026-03-05 19:07:09 +0000 Commit: John Baldwin CommitDate: 2026-03-05 19:07:09 +0000 acpi: Don't attach a "wake" sysctl node to devices without the ACPI flags IVAR Not all bus drivers for ACPI-aware devices implement the ACPI flags IVAR used by the acpi_wake_set_sysctl handler. In some cases this may be a feature as some new-bus devices share the same ACPI handle (e.g. a pcibX device and its child pciY device) which can lead to confusing results (e.g. setting the sysctl on pciY changes the behavior of the parent pcibX device, but the "wake" sysctl for pcibX won't reflect the new behavior, or reflect the device's state). Reviewed by: obiwac, ngie, imp Differential Revision: https://reviews.freebsd.org/D55562 --- sys/dev/acpica/acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/acpica/acpi.c b/sys/dev/acpica/acpi.c index 3a664523c27e..01b584ec30aa 100644 --- a/sys/dev/acpica/acpi.c +++ b/sys/dev/acpica/acpi.c @@ -3951,7 +3951,7 @@ acpi_wake_sysctl_walk(device_t dev) for (i = 0; i < numdevs; i++) { child = devlist[i]; acpi_wake_sysctl_walk(child); - if (!device_is_attached(child)) + if (!device_is_attached(child) || !acpi_has_flags(child)) continue; status = AcpiEvaluateObject(acpi_get_handle(child), "_PRW", NULL, NULL); if (ACPI_SUCCESS(status)) {