From owner-cvs-src@FreeBSD.ORG Thu Mar 27 14:34:29 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66D0137B404 for ; Thu, 27 Mar 2003 14:34:29 -0800 (PST) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 405624405D for ; Thu, 27 Mar 2003 14:34:27 -0800 (PST) (envelope-from silby@silby.com) Received: (qmail 35348 invoked from network); 27 Mar 2003 22:34:26 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay.pair.com with SMTP; 27 Mar 2003 22:34:26 -0000 X-pair-Authenticated: 209.68.2.70 Date: Thu, 27 Mar 2003 16:31:02 -0600 (CST) From: Mike Silbersack To: Bosko Milekic In-Reply-To: <20030327171501.GA18549@unixdaemons.com> Message-ID: <20030327163012.F748@odysseus.silby.com> References: <200303260452.h2Q4quap015364@www.ambrisko.com> <20030326183351.GJ57674@elvis.mu.org> <20030327013224.P7674@odysseus.silby.com> <20030327165800.GK57674@elvis.mu.org> <20030327171501.GA18549@unixdaemons.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Status: No, hits=-25.6 required=5.0 tests=AWL,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, QUOTE_TWICE_1,REFERENCES,REPLY_WITH_QUOTES autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf options src/sys/netinet ip_output.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2003 22:34:31 -0000 I'll give this a shot when I get time to work on the patch next. If a similar change to m_dup_pkthdr works fine, do you want me to go ahead and commit it? Thanks, Mike "Silby" Silbersack On Thu, 27 Mar 2003, Bosko Milekic wrote: > > See attached. Similar logic may be applied to m_dup_pkthdr(). > > On Thu, Mar 27, 2003 at 05:58:00PM +0100, Maxime Henrion wrote: > > Bosko Milekic wrote: > > > > > > Can you please still use m_gethdr() or m_getcl() to do the allocations > > > in the defragment function? Similarly, for > MCLBYTES, use m_getm(). > > > Don't roll your own. > > > > Please see my reply to Mike for the first version of his patch. He > > couldn't do this because m_dup_pkthdr() has a KASSERT() that makes it > > panic if we have a cluster attached to the mbuf. > > > > Cheers, > > Maxime > > > > -- > Bosko Milekic > bmilekic@unixdaemons.com > bmilekic@FreeBSD.org > >