From owner-cvs-src@FreeBSD.ORG Thu Mar 18 09:11:03 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED8D616A4CE; Thu, 18 Mar 2004 09:11:03 -0800 (PST) Received: from electra.cse.Buffalo.EDU (electra.cse.Buffalo.EDU [128.205.32.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FF3043D1F; Thu, 18 Mar 2004 09:11:03 -0800 (PST) (envelope-from kensmith@cse.Buffalo.EDU) Received: from electra.cse.Buffalo.EDU (kensmith@localhost [127.0.0.1]) i2IHB32Z011329; Thu, 18 Mar 2004 12:11:03 -0500 (EST) Received: (from kensmith@localhost) by electra.cse.Buffalo.EDU (8.12.10/8.12.9/Submit) id i2IHB2F9011328; Thu, 18 Mar 2004 12:11:02 -0500 (EST) Date: Thu, 18 Mar 2004 12:11:02 -0500 From: Ken Smith To: "Brian F. Feldman" Message-ID: <20040318171102.GA11248@electra.cse.Buffalo.EDU> References: <200403052239.i25MdrWA014794@repoman.freebsd.org> <200403172114.i2HLEii8028579@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200403172114.i2HLEii8028579@green.homeunix.org> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: John Baldwin Subject: Re: cvs commit: src/sys/kern kern_exit.c kern_sig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Mar 2004 17:11:04 -0000 On Wed, Mar 17, 2004 at 04:14:44PM -0500, Brian F. Feldman wrote: > John Baldwin wrote: > > jhb 2004/03/05 14:39:53 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_exit.c kern_sig.c > > Log: > > - Push down Giant in exit() and wait(). > > - Push Giant down a bit in coredump() and call coredump() with the proc > > lock already held rather than unlocking it only to turn around and > > relock it. > > Please review this to remove any places VFS is called into without Giant, > i.e. vrele(tracevp). > It's possible the alpha ref machine is suffering from this the past two days: panic: mutex Giant not owned at ../../../kern/vfs_subr.c:899 at line 719 in file ../../../kern/kern_mutex.c cpuid = 0; Stack backtrace: db_print_backtrace() at db_print_backtrace+0x18 backtrace() at backtrace+0x2c __panic() at __panic+0x210 _mtx_assert() at _mtx_assert+0xec vinvalbuf() at vinvalbuf+0x5c vclean() at vclean+0xc4 vgonel() at vgonel+0x74 vgone() at vgone+0x4c pfs_exit() at pfs_exit+0x80 exit1() at exit1+0x40c sys_exit() at sys_exit+0x24 syscall() at syscall+0x37c XentSys() at XentSys+0x64 --- syscall (1) --- --- user mode --- boot() called on cpu#0 -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel |