From owner-svn-src-head@freebsd.org Thu Jan 16 03:35:20 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A4E1122798D; Thu, 16 Jan 2020 03:35:20 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47yqZv6CqSz4P7k; Thu, 16 Jan 2020 03:35:19 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi1-f178.google.com with SMTP id c16so17691466oic.3; Wed, 15 Jan 2020 19:35:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=GHgzuLeJ0qMMOuz87c/O2vf2lpKU3po7jfjj1DeZDcA=; b=m6s13VVw97iK2cXECOnulijQSI24+BTwBLtANR9jX3PpmLzgWwff7ButVE0A06Avna 1XIAwGxKJJ5f+wl/Gw/szWoQGwVNOq5r58TtXXtnAX/rzQNEPjfy1L70k76HJXyEMY0p w1putyDB7lkIcWvGrIH+fOWW6M5bFdkxaXzQuhUWKqtLB5HtL0GOUKn94La63yw7Qrt6 2xbF/DqelfNXabdTZv3fXmNEQhVILjNGZvdx1J3nVJvtPRjrWgsGmBbOhsoIJfdIFyKL WhUDCx02ATEEiZFMEm1lWK8fb1EHkS7rJUHSVSXyLJmxDae0XS/I9pZ+SBZWVMxoCnAY Jk0w== X-Gm-Message-State: APjAAAV+SpF3MRPpWItCl/wNK3/2EQafJp77yR1XNjCHgnnJ1vovMrcj DZok9O/6MgGLgGyXgG9mZ1tJQw/Q X-Google-Smtp-Source: APXvYqyKlsAzQ7YZhdr873heX02ZaIAekxQwhnHYuQXzP3YT/xI0Q+V1tLMDbATplQSQoUYPFP8qcw== X-Received: by 2002:aca:2407:: with SMTP id n7mr2660153oic.14.1579145718646; Wed, 15 Jan 2020 19:35:18 -0800 (PST) Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com. [209.85.167.171]) by smtp.gmail.com with ESMTPSA id g61sm7325279otb.53.2020.01.15.19.35.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jan 2020 19:35:18 -0800 (PST) Received: by mail-oi1-f171.google.com with SMTP id c77so17664567oib.7; Wed, 15 Jan 2020 19:35:18 -0800 (PST) X-Received: by 2002:aca:4b06:: with SMTP id y6mr2623190oia.81.1579145718234; Wed, 15 Jan 2020 19:35:18 -0800 (PST) MIME-Version: 1.0 References: <202001150605.00F65Kc8011526@repo.freebsd.org> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Wed, 15 Jan 2020 19:35:07 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys To: Warner Losh Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47yqZv6CqSz4P7k X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-3.08 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[178.167.85.209.list.dnswl.org : 127.0.5.0]; HAS_REPLYTO(0.00)[cem@freebsd.org]; IP_SCORE(-1.08)[ip: (-0.46), ipnet: 209.85.128.0/17(-3.08), asn: 15169(-1.83), country: US(-0.05)]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[178.167.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jan 2020 03:35:20 -0000 On Wed, Jan 15, 2020 at 12:36 PM Warner Losh wrote: > Everywhere else in the system, it's fnp, argp for ordering the args... You'd be hard pressed to find exceptions to this rule. Since this is a new interface, we should fix it now while we still can :) qsort_r() is one exception (and that ordering is a mistake in many ways). +1 to Gleb's proposed new world order.