From owner-freebsd-hackers@freebsd.org Thu Jan 2 23:47:48 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6F11C1DF975 for ; Thu, 2 Jan 2020 23:47:48 +0000 (UTC) (envelope-from crees@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 47pl8N2Qhyz49Vf for ; Thu, 2 Jan 2020 23:47:48 +0000 (UTC) (envelope-from crees@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 533061DF973; Thu, 2 Jan 2020 23:47:48 +0000 (UTC) Delivered-To: hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 52EF41DF972 for ; Thu, 2 Jan 2020 23:47:48 +0000 (UTC) (envelope-from crees@freebsd.org) Received: from mail263c50.megamailservers.eu (mail1421c50.megamailservers.eu [91.136.14.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47pl8M5P8Lz49Vc; Thu, 2 Jan 2020 23:47:47 +0000 (UTC) (envelope-from crees@freebsd.org) X-Authenticated-User: crees@uwclub.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1578008865; bh=e8nNrypZyGtFKYsfAtCWg01RKg4PI6yxtbRSY5c5E18=; h=Date:Subject:To:From:From; b=lG+NpUQ767mno0cerdpZFSxbTwtvtJBRwIIKzX72m5ORUS5gCInIsbsvqXDExbZSW YaHoWSo11oDEqJtjwTTcK8H1pypo2jfvby8KLfPXaFtwfq/Y0cQXZF9i6BG+0ILVvb HD15NohcNzGuI/HBvg51uIivXQZmt8xOQ92ywUwM= Feedback-ID: crees@freebsd.o Received: from pegasus.bayofrum.net (host-92-16-36-61.as13285.net [92.16.36.61]) (authenticated bits=0) by mail263c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 002NlhKS025404; Thu, 2 Jan 2020 23:47:45 +0000 Received: from R.bayofrum.net (R.bayofrum.net [192.168.1.72]) by pegasus.bayofrum.net (Postfix) with ESMTPSA id AA6153A15; Thu, 2 Jan 2020 23:47:41 +0000 (GMT) Date: Thu, 02 Jan 2020 23:47:42 +0000 User-Agent: K-9 Mail for Android MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Fixing audio/oss to use callout instead of timeouts To: hackers@FreeBSD.org, jhb@freebsd.org From: Chris Rees Message-ID: X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: AA6153A15.A8732 X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: crees@freebsd.org X-Spam-Status: No X-CTCH-RefID: str=0001.0A0B020A.5E0E8121.0010, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=II989TnG c=1 sm=1 tr=0 a=ExehvxHEHCe6C2o3spqpZQ==:117 a=ExehvxHEHCe6C2o3spqpZQ==:17 a=IkcTkHD0fZMA:10 a=Jdjhy38mL1oA:10 a=ZB5LerlCAAAA:8 a=6I5d2MoRAAAA:8 a=s7OjfW73dhMWR-UkQPkA:9 a=QEXdDO2ut3YA:10 a=YKPTzOroS2oaEK2QgPcx:22 a=IjZwj45LgO3ly-622nXo:22 a=Z5ABNNGmrOfJ6cZ5bIyy:22 a=bWyr8ysk75zN3GCy5bjg:22 X-Rspamd-Queue-Id: 47pl8M5P8Lz49Vc X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.94 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.95)[-0.953,0]; NEURAL_HAM_LONG(-0.99)[-0.989,0]; ASN(0.00)[asn:9115, ipnet:91.136.0.0/17, country:GB] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jan 2020 23:47:48 -0000 Hi Hackers (and perhaps John, as the author of r355732, sorry for the dupli= cate), I've attempted to use the callout functions instead of the now removed time= out functions for audio/oss, and I *think* that the code already stores and= retrieves the list of handlers, so it should be a simple swap out. I've made this modification and run the module with mpg123 for a while and = it hasn't killed my laptop, but I'd just like to check that I have the prin= ciple correct and haven't missed anything obvious. Please would you let me know if there is anything else I should have done? https://www.bayofrum.net/cgi-bin/fossil/oss/vinfo/ad269d7cbc02bf38?diff=3D2 (This is the change I've made to kernel/OS/FreeBSD/os_freebsd.c in oss) https://www.bayofrum.net/cgi-bin/fossil/oss/vinfo/ad269d7cbc02bf38?diff=3D2= &dc=3D9999 (This is the whole file with changes highlighted.) Thanks! Chris https://reviews.freebsd.org/rS355732 --=20 This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.