From owner-svn-src-all@FreeBSD.ORG Mon May 24 16:18:16 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACDA81065674; Mon, 24 May 2010 16:18:16 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 4F6018FC12; Mon, 24 May 2010 16:18:14 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA04482; Mon, 24 May 2010 19:18:13 +0300 (EEST) (envelope-from avg@freebsd.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1OGaM1-000Byz-EZ; Mon, 24 May 2010 19:18:13 +0300 Message-ID: <4BFAA6C4.3040706@freebsd.org> Date: Mon, 24 May 2010 19:18:12 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.24 (X11/20100321) MIME-Version: 1.0 To: Alexander Motin References: <201005241140.o4OBeova088506@svn.freebsd.org> <4BFA8F22.6040402@freebsd.org> <4BFAA409.4040008@FreeBSD.org> In-Reply-To: <4BFAA409.4040008@FreeBSD.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r208494 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include kern pc98/cbus sys x86/isa x86/x86 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 May 2010 16:18:16 -0000 on 24/05/2010 19:06 Alexander Motin said the following: > Andriy Gapon wrote: >> on 24/05/2010 14:40 Alexander Motin said the following: >>> Author: mav >>> Date: Mon May 24 11:40:49 2010 >>> New Revision: 208494 >>> URL: http://svn.freebsd.org/changeset/base/208494 >>> >>> Log: >>> - Implement MI helper functions, dividing one or two timer interrupts with >>> arbitrary frequencies into hardclock(), statclock() and profclock() calls. >>> Same code with minor variations duplicated several times over the tree for >>> different timer drivers and architectures. >>> - Switch all x86 archs to new functions, simplifying the code and removing >>> extra logic from timer drivers. Other archs are also welcome. >> could you please describe the new code/KPI in greater detail, perhaps on a more >> appropriate mailing list? > > Sent some summary to arch@. Thanks! >> For me it is not immediately obvious why IPI_PROFCLOCK is gone now. I haven't >> spent much time reverse engineering this change and perhaps it's easier for you >> to describe the change. > > IPI_PROFCLOCK is not used any more. Separation between statclock() and > profclock() now handled in common machine-independent code. Timer driver > generates interrupts, MD code manages timers configuration and events > redistribution to every CPU, using up to two IPIs if needed, MI code do > the rest of things. Thank you for the explanation. BTW, with e.g. HPET we may consider using a separate clock for profiling, but I am not sure. -- Andriy Gapon