From owner-svn-src-all@FreeBSD.ORG Tue Oct 22 15:47:14 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 8A9D0FE; Tue, 22 Oct 2013 15:47:14 +0000 (UTC) (envelope-from nwhitehorn@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7809C23B2; Tue, 22 Oct 2013 15:47:14 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r9MFlEVs084229; Tue, 22 Oct 2013 15:47:14 GMT (envelope-from nwhitehorn@svn.freebsd.org) Received: (from nwhitehorn@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r9MFlEtu084228; Tue, 22 Oct 2013 15:47:14 GMT (envelope-from nwhitehorn@svn.freebsd.org) Message-Id: <201310221547.r9MFlEtu084228@svn.freebsd.org> From: Nathan Whitehorn Date: Tue, 22 Oct 2013 15:47:14 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r256914 - head/sys/powerpc/powerpc X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2013 15:47:14 -0000 Author: nwhitehorn Date: Tue Oct 22 15:47:13 2013 New Revision: 256914 URL: http://svnweb.freebsd.org/changeset/base/256914 Log: Ignore registers on devices where the reg property is malformed. Issue a warning if this happens under bootverbose. This prevents some strange-looking entries in dmesg for SMU devices on Apple G5 systems. Modified: head/sys/powerpc/powerpc/nexus.c Modified: head/sys/powerpc/powerpc/nexus.c ============================================================================== --- head/sys/powerpc/powerpc/nexus.c Tue Oct 22 15:46:21 2013 (r256913) +++ head/sys/powerpc/powerpc/nexus.c Tue Oct 22 15:47:13 2013 (r256914) @@ -567,6 +567,12 @@ nexus_setup_dinfo(device_t dev, phandle_ nreg = OF_getprop_alloc(node, "reg", sizeof(*reg), (void **)®); if (nreg == -1) nreg = 0; + if (nreg % (sc->acells + sc->scells) != 0) { + if (bootverbose) + device_printf(dev, "Malformed reg property on <%s>\n", + ndi->ndi_obdinfo.obd_name); + nreg = 0; + } for (i = 0; i < nreg; i += sc->acells + sc->scells) { phys = size = 0;