Date: Sat, 17 Jan 2015 23:18:27 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Jason Wolfe <nitroboost@gmail.com>, John Baldwin <jhb@freebsd.org> Cc: Adrian Chadd <adrian@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org>, Sean Bruno <sbruno@freebsd.org>, "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: [RFC] kern/kern_timeout.c rewrite in progress Message-ID: <54BADFB3.3030405@selasky.org> In-Reply-To: <CAAAm0r0S=s8pRHR3-h%2BntEt27cw6tshHCONSezaAr3zBhLhSWA@mail.gmail.com> References: <54A1B38C.1000709@selasky.org> <20150101005613.4f788b0c@nonamehost.local> <54A49CA5.2060801@selasky.org> <54A4A002.8010802@selasky.org> <54A53F4F.2000003@selasky.org> <54A92ED1.2070906@selasky.org> <CAJ-Vmo=tc-hqykhyc5bQW8qd_34PZU6yfGY8wziByA0xnR3ANQ@mail.gmail.com> <54A9A71E.70609@selasky.org> <CAAAm0r39Sv3TCvwaCiNQ1Y9iBVtY_nb0A_iNOC41bgxqXmt%2B4w@mail.gmail.com> <54B29A49.3080600@selasky.org> <CAAAm0r2eNYicq%2BKKj5f5EE%2BKLPxdvy15wj1ZWS=zA6sgOtcoGQ@mail.gmail.com> <54B67DA7.3070106@selasky.org> <54B7DECF.8070209@selasky.org> <CAAAm0r0S=s8pRHR3-h%2BntEt27cw6tshHCONSezaAr3zBhLhSWA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/17/15 20:11, Jason Wolfe wrote: > > HPS, > > Just to give a quick status update, this patch has most certainly > resolved our spin lock held too long panics on stable/10. > > Thank you to JHB for spending some time digging into the issue and > leading us to td_slpcallout as the culprit, and HPS for your rewrite. > I had heard rumors of other being affected by similar issues, so this > seems like a fine candidate for an MFC if possible. > > Jason > Hi Jason, I'm glad to hear that my patch has resolved your issue and I'm happy we now have a more stable system. It was actually a co-worker at work which wrote some bad code which I started debugging which then lead me to look at the callout subsystem. One bug kills the other ;-) I'm planning a MFC to 10-stable - yes, and will possibly add the _callout_stop_safe() function to not break binary compatibility with existing drivers as part of the MFC. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54BADFB3.3030405>