From owner-freebsd-arch@FreeBSD.ORG  Sat Jan 17 22:17:48 2015
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A710CC85;
 Sat, 17 Jan 2015 22:17:48 +0000 (UTC)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5A112FAE;
 Sat, 17 Jan 2015 22:17:48 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id B41C31FE023;
 Sat, 17 Jan 2015 23:17:38 +0100 (CET)
Message-ID: <54BADFB3.3030405@selasky.org>
Date: Sat, 17 Jan 2015 23:18:27 +0100
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Jason Wolfe <nitroboost@gmail.com>, John Baldwin <jhb@freebsd.org>
Subject: Re: [RFC] kern/kern_timeout.c rewrite in progress
References: <54A1B38C.1000709@selasky.org>	<20150101005613.4f788b0c@nonamehost.local>	<54A49CA5.2060801@selasky.org>	<54A4A002.8010802@selasky.org>	<54A53F4F.2000003@selasky.org>	<54A92ED1.2070906@selasky.org>	<CAJ-Vmo=tc-hqykhyc5bQW8qd_34PZU6yfGY8wziByA0xnR3ANQ@mail.gmail.com>	<54A9A71E.70609@selasky.org>	<CAAAm0r39Sv3TCvwaCiNQ1Y9iBVtY_nb0A_iNOC41bgxqXmt+4w@mail.gmail.com>	<54B29A49.3080600@selasky.org>	<CAAAm0r2eNYicq+KKj5f5EE+KLPxdvy15wj1ZWS=zA6sgOtcoGQ@mail.gmail.com>	<54B67DA7.3070106@selasky.org>	<54B7DECF.8070209@selasky.org>
 <CAAAm0r0S=s8pRHR3-h+ntEt27cw6tshHCONSezaAr3zBhLhSWA@mail.gmail.com>
In-Reply-To: <CAAAm0r0S=s8pRHR3-h+ntEt27cw6tshHCONSezaAr3zBhLhSWA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Adrian Chadd <adrian@freebsd.org>,
 FreeBSD Current <freebsd-current@freebsd.org>, Sean Bruno <sbruno@freebsd.org>,
 "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org>
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Jan 2015 22:17:48 -0000

On 01/17/15 20:11, Jason Wolfe wrote:
>
> HPS,
>
> Just to give a quick status update, this patch has most certainly
> resolved our spin lock held too long panics on stable/10.
>
> Thank you to JHB for spending some time digging into the issue and
> leading us to td_slpcallout as the culprit, and HPS for your rewrite.
> I had heard rumors of other being affected by similar issues, so this
> seems like a fine candidate for an MFC if possible.
>
> Jason
>

Hi Jason,

I'm glad to hear that my patch has resolved your issue and I'm happy we 
now have a more stable system.

It was actually a co-worker at work which wrote some bad code which I 
started debugging which then lead me to look at the callout subsystem. 
One bug kills the other ;-)

I'm planning a MFC to 10-stable - yes, and will possibly add the 
_callout_stop_safe() function to not break binary compatibility with 
existing drivers as part of the MFC.

--HPS