From owner-cvs-src@FreeBSD.ORG  Sat Sep 24 03:45:31 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6173616A41F;
	Sat, 24 Sep 2005 03:45:31 +0000 (GMT)
	(envelope-from delphij@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3094B43D48;
	Sat, 24 Sep 2005 03:45:31 +0000 (GMT)
	(envelope-from delphij@FreeBSD.org)
Received: from freefall.freebsd.org (delphij@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j8O3jVaT008108;
	Sat, 24 Sep 2005 03:45:31 GMT
	(envelope-from delphij@freefall.freebsd.org)
Received: (from delphij@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j8O3jV31008107;
	Sat, 24 Sep 2005 03:45:31 GMT (envelope-from delphij)
Date: Sat, 24 Sep 2005 03:45:30 +0000
From: Xin LI <delphij@FreeBSD.org>
To: "Christian S.J. Peron" <csjp@FreeBSD.org>
Message-ID: <20050924034530.GA7939@freefall.freebsd.org>
References: <200509232049.j8NKnvIj024351@repoman.freebsd.org>
	<20050923210402.GA50245@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050923210402.GA50245@freefall.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/ufs/ufs ufs_inode.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Sep 2005 03:45:31 -0000

On Fri, Sep 23, 2005 at 09:04:02PM +0000, Christian S.J. Peron wrote:
> On Fri, Sep 23, 2005 at 08:49:57PM +0000, Xin LI wrote:
> [..]
> >   Log:
> >   Restore a historical ufs_inactive behavior that has been changed
> >   in rev. 1.40 of ufs_inode.c, which allows an inode being truncated
> >   even when the filesystem itself is marked RDONLY.  A subsequent
> >   call of UFS_TRUNCATE (ffs_truncate) would panic the system as it
> >   asserts that it can only be called when the filesystem is mounted
> >   read-write (same changeset, rev. 1.74 of sys/ufs/ffs/ffs_inode.c).
> >   
> 
> Just to make sure that I am understanding you correctly here: You have
> restored a behaviour which can result in inode truncation, even on read
> only filesystems? Or you removed this behaviour?

Er...  My bad English...

I mean that "No writes to read-only file system" behavior was restored.
Rev. 1.40 allows some writes to read-only filesystem, which can cause
problem when mounting a corrupted problem.

Cheers,