From nobody Wed Mar 11 17:15:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fWHSm21QYz6VSPN for ; Wed, 11 Mar 2026 17:15:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fWHSm1H6gz3Zvt for ; Wed, 11 Mar 2026 17:15:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773249336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KGrKZbEUGz5u+CaELk8n6BRj0yltdkFEvhv/rvxk/bI=; b=QcF14jjV3xP2KsDKjNeHb6ZqdYYgbKDC0vBbQ6ZrmPVdJTfmKNeLvzw38mc9HxAwplxLIf pIEZ6er63dUU4uF8xYyoU7UYoWbYN99B+dns78Cad7l/Ul28ZJGqOL5RkjXBkBMID6Vb9v Ul4H6NlHQrUP3HtKAOqsgulsWYyR4cJ8MaUTP8Cht5fyKwVfVHTubuSTnbigDi9J57NvR8 49wFdNlJivI1BWNAOSBigExXlikB3DmHTc7Vdi+4zPoBUbhsqsirX3PQ3L5w0liXIsMs+x DGa7W6WuUTpHwUNogueE6kzUsQ63o2M88CM8NR/GJuIQbxJNbgVzC5hB+MBSOw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773249336; a=rsa-sha256; cv=none; b=I+7OWBPGE7YZuthbThYNTHFhzRPkYIZVMjvBLUp8l0xRtmksrq4Fv5PbN8TB0Hm8E4xGpB G8ZxmhTc94iVBE78/6n346Iof/o8K5179YDIc/TeuV23TwzRHKFesi8uQFVTfec9xcJT/G uhTlPfW4EuHDj9H27SD2pjyvZfj41FE/++MoGu7v2BZLhAlnUuL/HNbp6DIplafB1sBIBQ jkP5JXNa6V2DQs2XX6bp9hT54zpeIIYb2Aw5VB5T0pNKovREiadyZgjgwUAzLonc8nhabL X1hExQws0lvzMY8YFU8tBLUJg8aK7G1+Q/8vWBK9B7bPky8gRUEPH8vMOlMy4g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773249336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KGrKZbEUGz5u+CaELk8n6BRj0yltdkFEvhv/rvxk/bI=; b=EzqbXgOnSvTbXq1HxI/YIwmO3zSIq7JzaHXNwQ8hBliv/Q0botJy7Yf0b3U9mU4ifJW258 ytZ+pAhQ2hhFHc9Dxz7FfXHE9oPoewkggm7oNcZo58kCtqi8XyQCRbwrk5DfooGocZXu/I zS71F79VV0lzKQl+0ziYPtKel4g7foW6Lj55u1qWXz5nnWo/pRZsIEqY1+CtA1SGRmqna9 yd+UKzfS7iVgO/Zw4SxFrVsHhio3Gucz9tGMJoGRNxl5vCUgFp9WNUqcksgTypS9DDYs4+ GCZJu5CmuOm4dEBhWFPp2t5xzhdbCFGyqKVVSoWK62aqMWt37Y3PV0rNvJ1lDg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fWHSm0rBSz176v for ; Wed, 11 Mar 2026 17:15:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 47872 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Mar 2026 17:15:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Siva Mahadevan Subject: git: b9c0e0c77036 - stable/14 - LinuxKPI: avoid -Werror=unused-value in sort() from BUILD_BUG_ON_ZERO() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: siva X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b9c0e0c77036a83b2d1b6993224370b686446d6a Auto-Submitted: auto-generated Date: Wed, 11 Mar 2026 17:15:36 +0000 Message-Id: <69b1a338.47872.72a1d082@gitrepo.freebsd.org> The branch stable/14 has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=b9c0e0c77036a83b2d1b6993224370b686446d6a commit b9c0e0c77036a83b2d1b6993224370b686446d6a Author: Siva Mahadevan AuthorDate: 2026-03-03 19:09:35 +0000 Commit: Siva Mahadevan CommitDate: 2026-03-11 16:45:36 +0000 LinuxKPI: avoid -Werror=unused-value in sort() from BUILD_BUG_ON_ZERO() The BUILD_BUG_ON_ZERO() macro returns an (int)0 if it does not fail at build time. LinuxKPI sort() has it as a guard for an unsupported argument but ignores the return value. This leads to gcc complaining: /usr/src/sys/compat/linuxkpi/common/include/linux/build_bug.h:60:33: error: statement with no effect [-Werror=unused-value] 60 | #define BUILD_BUG_ON_ZERO(x) ((int)sizeof(struct { int:-((x) != 0); })) | ^ /usr/src/sys/compat/linuxkpi/common/include/linux/sort.h:37:9: note: in expansion of macro 'BUILD_BUG_ON_ZERO' 37 | BUILD_BUG_ON_ZERO(swap); \ | ^~~~~~~~~~~~~~~~~ /usr/src/sys/contrib/dev/rtw89/core.c:2575:9: note: in expansion of macro 'sort' 2575 | sort(drift, RTW89_BCN_TRACK_STAT_NR, sizeof(*drift), cmp_u16, NULL); Change to BUILD_BUG_ON() for the statement version. Reported by: CI Co-authored-by: bz Approved by: emaste (mentor) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D55634 (cherry picked from commit f26cb4757eb74ceace39144933ae198ebf1b4f28) --- sys/compat/linuxkpi/common/include/linux/sort.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/include/linux/sort.h b/sys/compat/linuxkpi/common/include/linux/sort.h index e6196d1f41c7..361b37c587c8 100644 --- a/sys/compat/linuxkpi/common/include/linux/sort.h +++ b/sys/compat/linuxkpi/common/include/linux/sort.h @@ -34,7 +34,7 @@ #include #define sort(base, num, size, cmp, swap) do { \ - BUILD_BUG_ON_ZERO(swap); \ + BUILD_BUG_ON(swap); \ qsort(base, num, size, cmp); \ } while (0)