From owner-cvs-src@FreeBSD.ORG Wed Aug 11 22:09:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13FB316A4CE; Wed, 11 Aug 2004 22:09:57 +0000 (GMT) Received: from pd5mo2so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 804D843D39; Wed, 11 Aug 2004 22:09:56 +0000 (GMT) (envelope-from colin.percival@wadham.ox.ac.uk) Received: from pd2mr3so.prod.shaw.ca (pd2mr3so-ser.prod.shaw.ca [10.0.141.108])2003)) with ESMTP id <0I2A00743YJ654@l-daemon>; Wed, 11 Aug 2004 16:01:54 -0600 (MDT) Received: from pn2ml3so.prod.shaw.ca ([10.0.121.147]) by pd2mr3so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0I2A003NMYJ6DQA0@pd2mr3so.prod.shaw.ca>; Wed, 11 Aug 2004 16:01:54 -0600 (MDT) Received: from piii600.wadham.ox.ac.uk ([24.87.233.42])2003)) with ESMTP id <0I2A0067XYJ5SR@l-daemon>; Wed, 11 Aug 2004 16:01:54 -0600 (MDT) Date: Wed, 11 Aug 2004 15:01:46 -0700 From: Colin Percival In-reply-to: <200408112030.i7BKU8oa085510@repoman.freebsd.org> X-Sender: cperciva@popserver.sfu.ca (Unverified) To: Andre Oppermann Message-id: <6.1.0.6.1.20040811145749.03f62170@popserver.sfu.ca> MIME-version: 1.0 X-Mailer: QUALCOMM Windows Eudora Version 6.1.0.6 Content-type: text/plain; charset=us-ascii References: <200408112030.i7BKU8oa085510@repoman.freebsd.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_divert.c raw_ip.c tcp_subr.c tcp_syncache.c udp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Aug 2004 22:09:57 -0000 At 13:30 11/08/2004, Andre Oppermann wrote: > Backout removal of UMA_ZONE_NOFREE flag for all zones which are established > for structures with timers in them. It might be that a timer might fire > even when the associated structure has already been free'd. Have you considered converting the callout_stop calls to callout_drain calls? (I don't know if it's possible here, since callout_drain sometimes picks up a sleep mutex. But killing callouts before freeing data structures is exactly the problem for which callout_drain was created.) Colin Percival