From owner-freebsd-arch@freebsd.org Tue Nov 14 04:35:08 2017 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10B3ECFF68D for ; Tue, 14 Nov 2017 04:35:08 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp004.me.com (mr11p00im-asmtp004.me.com [17.110.69.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E70836E090 for ; Tue, 14 Nov 2017 04:35:07 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from process-dkim-sign-daemon.mr11p00im-asmtp004.me.com by mr11p00im-asmtp004.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) id <0OZE00H004L3N800@mr11p00im-asmtp004.me.com> for freebsd-arch@freebsd.org; Tue, 14 Nov 2017 04:35:05 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=04042017; t=1510634105; bh=Zxwr6mNYsIQLrNjR3Hcf5RVYshD2EMf+75yrRQi1Phk=; h=Date:Subject:From:To:Message-id:MIME-version:Content-type; b=Amf0Ihe2ofcGtjqh1ztZp/Xziwdv6+js2jx6a2zfvHFR917RFGExYlNti78eBA4JF g7F0DGTL725TVScKyZo9XmXUOn4/3cgk3YFqXtBBayTnFQxkZJc+1XTmwGjxgipJTg KVGCBQ7awgUC7Q0oqmxgv4s1FXCQdaPLlGXrhTDDpUD5RTnrX57ELy/D9X1cN6SepZ zeoy/YmYvJ4AIPHbJ4sdOiweElzdvv2yuRlj/rv1oKKcqQsc+Akw0bmUKScIu3IuLG EbJaT+Q8BGswbe3pCatNxOsL27pGs6fYZzTjYd7+gjf6Q6eAPbQa0OSgBkgBVsaVKE X4vg0C3lm+Xaw== Received: from icloud.com ([127.0.0.1]) by mr11p00im-asmtp004.me.com (Oracle Communications Messaging Server 8.0.1.2.20170607 64bit (built Jun 7 2017)) with ESMTPSA id <0OZE00IPN4QERI00@mr11p00im-asmtp004.me.com>; Tue, 14 Nov 2017 04:35:03 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-14_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711140061 User-Agent: Microsoft-MacOutlook/f.27.0.171010 Date: Mon, 13 Nov 2017 20:35:02 -0800 Subject: Re: small patch for numactl. Comments? From: Ravi Pokala To: Larry McVoy , freebsd-arch@freebsd.org Cc: scottl@netflix.com, kbowling@llnw.com, gallatin@netflix.com Message-id: Thread-topic: small patch for numactl. Comments? References: <20171114020138.GA18863@mcvoy.com> In-reply-to: <20171114020138.GA18863@mcvoy.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2017 04:35:08 -0000 Hi Larry, Might I suggest a small wording change? Three "that"s in the same sentence is a little much. :-) > +so that programs that know that they need to be run under > +.Nm > +can check. +so programs which know that they need to be run under +.Nm , +can check. Also, I recommend installing textproc/igor, and using it to scan the manpage for common mistakes. Thanks, Ravi (rpokala@) -----Original Message----- From: on behalf of Larry McVoy Date: 2017-11-13, Monday at 18:01 To: Cc: , , Subject: small patch for numactl. Comments? Hi folks, some CDN people are dragging me out of retirement to work on FreeBSD. Which I have to say is sort of fun since I started my kernel hacking on SunOS 4.x which was a very very nice version of BSD. But FreeBSD has mostly caught up, so it's pleasant. I'm wacking LMbench to be numa aware and this patch would help me make sure that when you are a numa machine you could insist that people run the benchmark via numactl (imma gonna blog about numa, it sucks unless you are numa aware). I did some docs but I'm new to the FreeBSD man macros, would love feedback on how to do that right. --- numactl.1 2017-11-13 17:51:26.243473000 -0800 +++ numactl.1.lm 2017-11-13 17:51:20.494596000 -0800 @@ -107,6 +107,15 @@ .El .Sh EXIT STATUS .Ex -std +.Sh ENVIRONMENT +.Nm +sets the environment variable +\fINUMACTL=YES\fP +before running +.Ar cmd ... +so that programs that know that they need to be run under +.Nm +can check. .Sh EXAMPLES Create a .Pa /bin/sh --- numactl.c 2017-11-13 16:18:36.134359000 -0800 +++ numactl.c.lm 2017-11-13 16:18:28.530953000 -0800 @@ -231,6 +231,7 @@ (void) set_numa_domain_cpuaffinity(cpu_domain, CPU_WHICH_PID, -1); + putenv("NUMACTL=YES"); errno = 0; execvp(*argv, argv); err(errno == ENOENT ? 127 : 126, "%s", *argv); _______________________________________________ freebsd-arch@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-arch To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"