From owner-freebsd-bugs@FreeBSD.ORG Fri Dec 7 07:30:06 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A916A16A417 for ; Fri, 7 Dec 2007 07:30:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 991D113C44B for ; Fri, 7 Dec 2007 07:30:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id lB77U6A5050275 for ; Fri, 7 Dec 2007 07:30:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id lB77U6C5050272; Fri, 7 Dec 2007 07:30:06 GMT (envelope-from gnats) Date: Fri, 7 Dec 2007 07:30:06 GMT Message-Id: <200712070730.lB77U6C5050272@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Andrey V. Elsukov" Cc: Subject: Re: kern/118477: BETA4 installer doesn't attach my HDD controller; BETA3 did X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Andrey V. Elsukov" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2007 07:30:06 -0000 The following reply was made to PR kern/118477; it has been noted by GNATS. From: "Andrey V. Elsukov" To: Todd Wasson Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: kern/118477: BETA4 installer doesn't attach my HDD controller; BETA3 did Date: Fri, 07 Dec 2007 10:10:39 +0300 This is a multi-part message in MIME format. --------------010200000106090202080003 Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Todd Wasson wrote: > I've tried this with both i386 and amd64 install discs, with the > same results. I've also updated my BETA3 install to CURRENT and > built the kernel and run into this same error, so clearly some > code is checked into the tree now, as it was at the time > of BETA4's release, that is causing this issue. >> How-To-Repeat: > Boot the 7.0-BETA4 disc 1 install CD. Alternatively, csup to CURRENT from BETA3, build the kernel, and boot into it. >> Fix: Hi, Todd. Can you try the attached patch? -- WBR, Andrey V. Elsukov --------------010200000106090202080003 Content-Type: text/plain; name="ata-chipset.c.diff.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ata-chipset.c.diff.txt" --- src/sys/dev/ata/ata-chipset.c 2007-11-22 00:15:00.000000000 +0300 +++ src/sys/dev/ata/ata-chipset.c 2007-12-07 10:07:21.000000000 +0300 @@ -2243,7 +2243,7 @@ ata_jmicron_chipinit(device_t dev) return ENXIO; /* do we have multiple PCI functions ? */ - if (pci_read_config(dev, 0xdf, 1) & 0x40) { + if ((pci_read_config(dev, 0xdf, 1) & 0x40) || ctlr->chip->cfg1 == 0) { /* are we on the AHCI part ? */ if (ata_ahci_chipinit(dev) != ENXIO) return 0; --------------010200000106090202080003--