From owner-freebsd-current@FreeBSD.ORG Thu Jun 30 16:54:13 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C76F716A41C; Thu, 30 Jun 2005 16:54:13 +0000 (GMT) (envelope-from toa@pop.agri.ch) Received: from smtp.messaging.ch (exsmtp02.agrinet.ch [81.221.252.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5A88D43D48; Thu, 30 Jun 2005 16:54:12 +0000 (GMT) (envelope-from toa@pop.agri.ch) Received: from [192.168.225.5] ([80.218.0.93]) by smtp.messaging.ch with Microsoft SMTPSVC(6.0.3790.211); Thu, 30 Jun 2005 18:54:11 +0200 Message-ID: <42C423A9.3010603@pop.agri.ch> Date: Thu, 30 Jun 2005 18:54:01 +0200 From: Andreas Tobler User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Suleiman Souhlal References: <7mhdg4q983.wl%kuriyama@imgsrc.co.jp> <42C30E90.3030405@pop.agri.ch> <59D725CA-BB01-48D5-A2D8-B2D4A9E6B177@FreeBSD.org> In-Reply-To: <59D725CA-BB01-48D5-A2D8-B2D4A9E6B177@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 30 Jun 2005 16:54:11.0214 (UTC) FILETIME=[56A3E2E0:01C57D94] Cc: Current Subject: Re: Acquiring lockmgr lock "ufs" with non-sleepable locks X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2005 16:54:13 -0000 Hello Suleiman, Suleiman Souhlal wrote: >>> This was introduced by my commit to take out the various kqueue >>> operations outside of ufs. It is because we are trying to lock the >>> vnode while holding the knlist mutex. I'll work on a fix on >>> wednesday, as I'll unfortunately be a bit busy until then. I hope >>> this won't cause you any inconvenience. >>> >> >> Is the below the same ? > > > Yes. > >> No, I did not try the follow-up patch yet. > > > The patch should fix it. I'll commit it as soon as I get approval. It did :) Thanks. The tail -f file works now. Though, I took the latest diff from your site (knlist_locking-20050629-2.diff) and had to add the thing below, you forgot a NULL in knlist_init. Regards, Andreas (p.s: patch hand edited) Index: src/sys/cam/scsi/scsi_target.c =================================================================== --- src/sys/cam/scsi/scsi_target.c (revision 187) +++ src/sys/cam/scsi/scsi_target.c (working copy) @@ -196,7 +196,7 @@ TAILQ_INIT(&softc->work_queue); TAILQ_INIT(&softc->abort_queue); TAILQ_INIT(&softc->user_ccb_queue); - knlist_init(&softc->read_select.si_note, &softc->mtx); + knlist_init(&softc->read_select.si_note, &softc->mtx, NULL, NULL, NULL); return (0); }