From owner-freebsd-current  Thu May 11 14:08:49 1995
Return-Path: current-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id OAA13779
          for current-outgoing; Thu, 11 May 1995 14:08:49 -0700
Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93])
          by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id OAA13773
          for <current@freebsd.org>; Thu, 11 May 1995 14:08:43 -0700
Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <14814(3)>; Thu, 11 May 1995 14:03:44 PDT
Received: by crevenia.parc.xerox.com id <49859>; Thu, 11 May 1995 14:03:39 -0700
From: Bill Fenner <fenner@parc.xerox.com>
To: current@FreeBSD.org
Subject: IP_ACCT set/getsockopts?
Message-Id: <95May11.140339pdt.49859@crevenia.parc.xerox.com>
Date: Thu, 11 May 1995 14:03:38 PDT
Sender: current-owner@FreeBSD.org
Precedence: bulk

I was munging around with the multicast set/getsockopts, and on my way there,
I found:

        case IP_ACCT_DEL:
        case IP_ACCT_ADD:
        case IP_ACCT_CLR:
        case IP_ACCT_FLUSH:
        case IP_ACCT_ZERO:
...
 
                op = PRCO_SETOPT;
                if (op) {
                        error=(*ip_acct_ctl_ptr)(optname, *m);
                        if (*m)
                                (void)m_free(*m);
                }

Uh, what?  Seems to me that this should be more like

		if (op == PRCO_SETOPT) {
			...
		} else
			error = EINVAL;

(Unless, of course, having a getsockopt(..,IP_ACCT_ADD,..) panic the kernel
 is a desired effect...)

  Bill