Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 11 May 1995 14:03:38 PDT
From:      Bill Fenner <fenner@parc.xerox.com>
To:        current@FreeBSD.org
Subject:   IP_ACCT set/getsockopts?
Message-ID:  <95May11.140339pdt.49859@crevenia.parc.xerox.com>
next in thread | raw e-mail | index | archive | help 
I was munging around with the multicast set/getsockopts, and on my way there,
I found:

        case IP_ACCT_DEL:
        case IP_ACCT_ADD:
        case IP_ACCT_CLR:
        case IP_ACCT_FLUSH:
        case IP_ACCT_ZERO:
...
 
                op = PRCO_SETOPT;
                if (op) {
                        error=(*ip_acct_ctl_ptr)(optname, *m);
                        if (*m)
                                (void)m_free(*m);
                }

Uh, what?  Seems to me that this should be more like

		if (op == PRCO_SETOPT) {
			...
		} else
			error = EINVAL;

(Unless, of course, having a getsockopt(..,IP_ACCT_ADD,..) panic the kernel
 is a desired effect...)

  Bill

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?95May11.140339pdt.49859>