From owner-svn-src-all@FreeBSD.ORG  Thu Jul 25 16:04:38 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 6507F8B4;
 Thu, 25 Jul 2013 16:04:38 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3CB7C2116;
 Thu, 25 Jul 2013 16:04:38 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 55B77B953;
 Thu, 25 Jul 2013 12:04:36 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: "David E. O'Brien" <obrien@freebsd.org>
Subject: Re: svn commit: r253618 - head/sys/dev/usb/gadget
Date: Wed, 24 Jul 2013 15:29:34 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; )
References: <201307241832.r6OIWFGc074918@svn.freebsd.org>
In-Reply-To: <201307241832.r6OIWFGc074918@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201307241529.35175.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Thu, 25 Jul 2013 12:04:37 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jul 2013 16:04:38 -0000

On Wednesday, July 24, 2013 2:32:15 pm David E. O'Brien wrote:
> Author: obrien
> Date: Wed Jul 24 18:32:15 2013
> New Revision: 253618
> URL: http://svnweb.freebsd.org/changeset/base/253618
> 
> Log:
>   per style(9):
>      Kernel include files (i.e. sys/*.h) come first; normally, include
>      <sys/types.h> OR <sys/param.h>, but not both.  <sys/types.h> includes
>      <sys/cdefs.h>, and it is okay to depend on that.

This is not fully correct.  The consistent style throughout the tree when
using _FBSDID() is:

#include <sys/cdefs.h>
__FBSDID()

#include <sys/param.h>
...

Please fix these to match that.  It might not be a bad idea to document the
__FBSDID() practice in style.9 while you are at it.

-- 
John Baldwin