From nobody Sun Jan 21 18:47:49 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TJ2RG48jWz57VS6 for ; Sun, 21 Jan 2024 18:47:54 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-42aa.mail.infomaniak.ch (smtp-42aa.mail.infomaniak.ch [84.16.66.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TJ2RD6BT2z4Svr for ; Sun, 21 Jan 2024 18:47:52 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=pyret.net header.s=20231006 header.b=JEbj52cz; dmarc=pass (policy=reject) header.from=pyret.net; spf=pass (mx1.freebsd.org: domain of daniel.engberg.lists@pyret.net designates 84.16.66.170 as permitted sender) smtp.mailfrom=daniel.engberg.lists@pyret.net Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4TJ2RB35CPzMrGSx; Sun, 21 Jan 2024 19:47:50 +0100 (CET) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4TJ2R96yFPzMpnPd; Sun, 21 Jan 2024 19:47:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pyret.net; s=20231006; t=1705862870; bh=14P9NYc2TLbUJkAfmkddJEv+/YPaQn5qQ6daeDeMBxI=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=JEbj52czXUAXLKjQGa6rZxXsC5uq2Dr25wlmLpnkhurV0x/DGV16iKKu3TwGVsvTB hYouvtQANx5YTbOYPUhl/jCZYT6HlQ368SMSCPiB1OWQgC1QWy6zm1zl8ftvPt0f7L woJBlLFOXg7ruqMIWe4usR+ffKi/QMZ5Wkph+6tgAaKj4ixvcbIYexgdkN7fCnmd9T Hphb+Su3UCfCuXzVM2OvYH2aHLMe/U7wINKPJMME8rWQ8zWQkc+Ei6uvGEIQGAhlAC Y4G/sHsrPcDqTO7nhQlOXatwahBn7K3rVrxHiZ+X1RT8s+6HM5HqHg9SVcWJK1gfZm 7Q0qOkygMQyhA== Message-ID: Date: Sun, 21 Jan 2024 19:47:49 +0100 Subject: Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple From: Daniel Engberg Reply-To: Daniel Engberg To: "Mikhail T." Cc: Kurt Jaeger , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1705862869_4a527cceade8370beb9467ac1a18eb1e_=_" X-WS-User-Origin: eyJpdiI6InF3dUFWeEdkQ0o3ajFyT1RvbjNSMFE9PSIsInZhbHVlIjoidE9UU3lhL2ZFMWNSbU1XZ2oxa0didz09IiwibWFjIjoiNjY2MmJhMWJlOTJjMWMzOGRjYjI0NDY3OWVmMzUzMDQ5MjAyZDJhNjM3Y2E3ZTkxNDRmY2NmY2NkN2NiNGM0MSIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6InZZWEVSWkdCTVB2QWZ6dUl4WFBWTkE9PSIsInZhbHVlIjoiY3MrLzRJbzZDNU8va2xhektFUnBmUT09IiwibWFjIjoiNDY5YzA5MWQ1ZTE1ZDk3Y2Y3NmZhZDcxMTFkYjc2YjliODJhMjZkZjI3ZmZkOTAyNWRlNzI2MDRlM2M0ZGE4YyIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.624) References: <202401202030.40KKUApC045320@gitrepo.freebsd.org> <7e07375b-32bc-4778-8977-d87d6e135679@virtual-estates.net> <8ab62f5f-bb62-4633-9d1c-d7a8a8e1fc8a@virtual-estates.net> <13433172-a8cb-494c-a435-fd4d8418a2e6@virtual-estates.net> <21dcca053d36f9bec4005ffb18897f51@mail.infomaniak.com> In-Reply-To: X-Infomaniak-Routing: alpha X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.30 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; URI_COUNT_ODD(1.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[pyret.net,reject]; R_SPF_ALLOW(-0.20)[+ip4:84.16.66.168/29]; RWL_MAILSPIKE_VERYGOOD(-0.20)[84.16.66.170:from]; R_DKIM_ALLOW(-0.20)[pyret.net:s=20231006]; RCVD_IN_DNSWL_LOW(-0.10)[84.16.66.170:from]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DKIM_TRACE(0.00)[pyret.net:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:29222, ipnet:84.16.64.0/19, country:CH]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org]; HAS_REPLYTO(0.00)[daniel.engberg.lists@pyret.net]; TAGGED_RCPT(0.00)[t]; REPLYTO_EQ_FROM(0.00)[] X-Rspamd-Queue-Id: 4TJ2RD6BT2z4Svr --_=_swift_1705862869_4a527cceade8370beb9467ac1a18eb1e_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-01-21T19:27:04.000+01:00, Mikhail T. w= rote: >=C2=A021.01.24=C2=A006:11,=C2=A0Daniel=C2=A0Engberg: >=C2= =A0 >>=C2=A0=C2=A0While=C2=A0neither=C2=A0Porters=C2=A0Handbook=C2=A0or= =C2=A0Committers=C2=A0Guide=C2=A0say=C2=A0it's=C2=A0a >>=C2=A0=C2=A0requi= rement=C2=A0it's=C2=A0quite=C2=A0strongly=C2=A0suggested=C2=A0that=C2=A0you= =C2=A0do=C2=A0use=C2=A0it. >=C2=A0 >=C2=A0Thank=C2=A0you,=C2=A0Daniel,= =C2=A0for=C2=A0confirming,=C2=A0no=C2=A0actual=C2=A0rules=C2=A0were=C2= =A0broken=C2=A0by=C2=A0my >=C2=A0commit. >=C2=A0 >>=C2=A0=C2=A0Given= =C2=A0that=C2=A0all=C2=A0pkg-fallout=C2=A0mails=C2=A0are=C2=A0from=C2=A0Pou= driere=C2=A0it's=C2=A0more=C2=A0or >>=C2=A0=C2=A0less=C2=A0implied=C2= =A0as=C2=A0committer=C2=A0to=C2=A0use=C2=A0it. >=C2=A0 >=C2=A0I=C2= =A0don't=C2=A0see=C2=A0the=C2=A0implication=C2=A0at=C2=A0all.=C2=A0I=C2= =A0appreciate=C2=A0the=C2=A0fallout >=C2=A0e-mails,=C2=A0but=C2=A0I=C2= =A0don't=C2=A0see,=C2=A0why=C2=A0that=C2=A0makes=C2=A0it=C2=A0mandatory= =C2=A0for=C2=A0me=C2=A0to=C2=A0use >=C2=A0the=C2=A0same=C2=A0tool(s)= =C2=A0locally.=C2=A0For=C2=A0example,=C2=A0the=C2=A0cluster=C2=A0builds= =C2=A0every=C2=A0port >=C2=A0on=C2=A0multiple=C2=A0hardware=C2=A0platform= s=C2=A0--=C2=A0for=C2=A0different=C2=A0OS-releases.=C2=A0Does >=C2=A0that= =C2=A0imply=C2=A0the=C2=A0committers=C2=A0also=C2=A0must=C2=A0have=C2=A0suc= h=C2=A0multitude=C2=A0of=C2=A0different >=C2=A0hardware/release=C2=A0comb= inations=C2=A0locally=C2=A0too? >=C2=A0 >=C2=A0I=C2=A0still=C2=A0don't= =C2=A0understand,=C2=A0why=C2=A0you=C2=A0asked=C2=A0me=C2=A0to=C2=A0backout= ...=C2=A0Mat's >=C2=A0attempt=C2=A0at=C2=A0answering=C2=A0amounted=C2= =A0to:=C2=A0"Because=C2=A0you=C2=A0broke=C2=A0the=C2=A0rules!"=C2=A0-- >= =C2=A0which=C2=A0is=C2=A0not=C2=A0a=C2=A0valid=C2=A0reason=C2=A0even=C2= =A0if=C2=A0any=C2=A0rules=C2=A0really=C2=A0were=C2=A0broken. >=C2=A0Clear= ly=C2=A0a=C2=A0personal=C2=A0thing...=C2=A0 >=C2=A0 >=C2=A0If=C2=A0the= =C2=A037=C2=A0seconds=C2=A0it=C2=A0took=C2=A0the=C2=A0cluster=C2=A0to=C2= =A0fail=C2=A0the=C2=A0port=C2=A0is=C2=A0really >=C2=A0such=C2=A0a=C2= =A0drain=C2=A0on=C2=A0the=C2=A0resources,=C2=A0marking=C2=A0the=C2=A0port= =C2=A0BROKEN=C2=A0would=C2=A0be=C2=A0a >=C2=A0thing=C2=A0to=C2=A0do=C2= =A0--=C2=A0that's=C2=A0a=C2=A0one-line=C2=A0change,=C2=A0that=C2=A0still= =C2=A0keeps=C2=A0the=C2=A0code >=C2=A0available=C2=A0for=C2=A0sharing. = >=C2=A0 >=C2=A0Anyway,=C2=A0I=C2=A0think,=C2=A0I=C2=A0hacked=C2=A0the= =C2=A0port=C2=A0into=C2=A0pre-fetching=C2=A0the=C2=A0additional >=C2= =A0modules=C2=A0using=C2=A0go.mk=C2=A0[http://go.mk]'s=C2=A0facilities,= =C2=A0and=C2=A0will=C2=A0be >=C2=A0committing=C2=A0that=C2=A0shortly.= =C2=A0It=C2=A0still=C2=A0is=C2=A0not=C2=A0perfect,=C2=A0because=C2=A0the= =C2=A0port >=C2=A0is=C2=A0a=C2=A0mixture=C2=A0of=C2=A0C=C2=A0and=C2=A0Go-= code,=C2=A0but=C2=A0it=C2=A0should=C2=A0build=C2=A0fine=C2=A0now.=C2=A0Than= k >=C2=A0you=C2=A0for=C2=A0the=C2=A0feedback.=C2=A0Yours, >=C2=A0 >>= =C2=A0=C2=A0-mi Hi, While we all do mistakes I'm asking because i= t's broken and it's likely not going to be fixed any time soon. In realit= y it adds noise (which we already have enough of) on lists, Poudriere bui= lds (because by default we build all ports) takes more time producing not= hing, more time for people to review error logs and so on. It boils down = to my time > your time which usually don't translate well in team efforts= . Instead of doing the same thing again use Poudriere as you're by kno= w well aware that it "should" be used and you have been "warned". I wou= ld also say that you'd be better off in general asking for suggestions by= creating a PR and or use Phab(ricator) due to quality reasons (to mentio= n it again, team effort). Best regards, Daniel --_=_swift_1705862869_4a527cceade8370beb9467ac1a18eb1e_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-01-21T19:27:04.000+01:00, Mikhail T. <mi+t@virtual-estates.= net> wrote:
<= blockquote class=3D"ws-ng-quote">
21.01.24 06:11, = Daniel Engberg:
While neither Porters Handbook or Committers Guide say it's a requirement it's quite strongly suggested that you do use it.


Thank you, Daniel, for confirming, no actual rules w= ere broken by my commit.

Given that all pkg-fallout mails are from Poudriere it's more or less implied as committer to use it.

I don't see the im= plication at all. I appreciate the fallout e-mails, but I don't see, why that makes it mandatory for me to use the same tool(s) locally. For example, the cluster builds every port on multiple hardware platforms -- for different OS-releases. Does that imply the committers also must have such multitude of different hardware/release combinations locally too?
=

I still don't understand, why you asked me to backout... Mat's attempt at answering amounted to: "Because you broke the rules!" -- which is not a valid reason even if any rules really were broken. Clearly a personal thing...

If the 37 seconds it t= ook the cluster to fail the port is really such a drain on the resources, marking the port BROKEN would be a thing to do -- that's a one-line change, that still keeps the code available for sharing.

Anyway, I think, I hacked the port i= nto pre-fetching the additional modules using go.mk<= /a>'s facilities, and will be committing that shortly. It still is not perfect, because the port is a mixture of C and Go-code, but it should build fine now. Thank you for the feedback. Yours,


-mi




--_=_swift_1705862869_4a527cceade8370beb9467ac1a18eb1e_=_--