From owner-cvs-ports@FreeBSD.ORG Sat Mar 8 13:38:29 2008 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BB2FD106566B; Sat, 8 Mar 2008 13:38:29 +0000 (UTC) (envelope-from brix@FreeBSD.org) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id 735328FC27; Sat, 8 Mar 2008 13:38:29 +0000 (UTC) (envelope-from brix@FreeBSD.org) Received: from tirith.brixandersen.dk (0x55534f5f.adsl.cybercity.dk [85.83.79.95]) by solow.pil.dk (Postfix) with ESMTP id C6A2B1CC0DD; Sat, 8 Mar 2008 14:38:27 +0100 (CET) Received: by tirith.brixandersen.dk (Postfix, from userid 1001) id EBF2611436; Sat, 8 Mar 2008 14:38:26 +0100 (CET) Date: Sat, 8 Mar 2008 14:38:26 +0100 From: Henrik Brix Andersen To: Gabor Kovesdan Message-ID: <20080308133826.GB77238@tirith.brixandersen.dk> Mail-Followup-To: Gabor Kovesdan , Gabor Kovesdan , ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org References: <200803032139.m23LdErR001683@repoman.freebsd.org> <20080306200730.GA60953@tirith.brixandersen.dk> <47D27E4E.5070505@kovesdan.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gatW/ieO32f1wygP" Content-Disposition: inline In-Reply-To: <47D27E4E.5070505@kovesdan.org> X-PGP-Key: http://www.brixandersen.dk/files/HenrikBrixAndersen.asc User-Agent: Mutt/1.5.17 (2007-11-01) Cc: cvs-ports@FreeBSD.org, Gabor Kovesdan , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/textproc/p5-Text-Markdown Makefile distinfo pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Mar 2008 13:38:29 -0000 --gatW/ieO32f1wygP Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 08, 2008 at 12:53:50PM +0100, Gabor Kovesdan wrote: > Henrik Brix Andersen escribi=F3: >> On Mon, Mar 03, 2008 at 09:39:14PM +0000, Gabor Kovesdan wrote: >> =20 >>> gabor 2008-03-03 21:39:14 UTC >>>=20 >>> FreeBSD ports repository >>>=20 >>> Modified files: >>> textproc/p5-Text-Markdown Makefile distinfo pkg-plist Log: >>> - Update 1.0.13 >>> - Better adjustement of dependencies >>> - Use PERL_CONFIGURE instead of PERL_MODBUILD >>> PR: ports/121027 >>> Submitted by: Felippe de Meirelles Motta >>> Approved by: maintainer >>> =20 >>=20 >> This update breaks at least www/ikiwiki... >>=20 >> Somehow, Text::MultiMarkdown is now known as both Text::MultiMarkdown >> and Text::Markdown on CPAN - (according to the change log, the authors >> actually planned to "steal" the Text::Markdown namespace for quite >> some time?) but it is not compatible with the original Text::Markdown >> (which is what we had as p5-Text-Markdown before this update). >>=20 >> The original version contained a Text::Markdown::Markdown() method, >> whereas MultiMarkdown contains a Text::Markdown::markdown() method, >> thus making the two incompatible (note the difference in >> capitalization of the method name). >>=20 >> I suggest backing this update out, restoring the original >> Text::Markdown functionality - and then perhaps committing this as >> p5-Text-MultiMarkdown, where it IMO belongs. >> =20 > Ok, I'll look at this more deeply soon, thanks for noticing this issue! I am currently running a patch [1] for www/ikiwiki which makes it work with either version of the Text::Markdown package through the ports tinderboxes. Since other - non-FreeBSD users - will also be bitten by this change in the Text::Markdown module, we might as well have it fixed properly. Perhaps other consumers of the textproc/p5-Text-Markdown will need similar patches. Brix [1]: http://people.freebsd.org/~brix/ports-patches/ikiwiki.diff --=20 Henrik Brix Andersen --gatW/ieO32f1wygP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) Comment: GnuPG signed iEYEARECAAYFAkfSltIACgkQv+Q4flTiePiR6ACgnnIfZuXHlAkWa2EvLL/KP1NW nJAAnA3ECIoFeI6NnyXEDQrt6D8VSepz =fevc -----END PGP SIGNATURE----- --gatW/ieO32f1wygP--