From owner-freebsd-arm@freebsd.org Sun Aug 18 14:23:33 2019 Return-Path: Delivered-To: freebsd-arm@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1E8D0C88E5 for ; Sun, 18 Aug 2019 14:23:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46BK6W60ZZz4ZWT for ; Sun, 18 Aug 2019 14:23:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x829.google.com with SMTP id l9so11348051qtu.6 for ; Sun, 18 Aug 2019 07:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YkinLbJksz74I3N/rbCFRP5hJarSOux5r2+/Li87NA0=; b=cJpp5rkoew6i3HhGZX5xB3pwi0kTEdoAOUAnJ5IBke83645dNb803XRpqpxPXbGt4Y sxrCIfkHeReyb9ylIjOQ4tG2LhurCMMuQY5PxLAvQmlQb7Xa4XjZks9vyIUrk3tW/o/2 2cyfmc1tYbSRBuWKOsLRb78FQkgTR70o5Zg4OKm7kRpeHtu9mqU93vdocXr6Mbg5/TGL pkDptMAoJXsonDBgGBJSIgHww9x+6akAbN9I46PNnisDwqm7i2Ez7vAVg+tElbDisw+M cIoo1fgIGGAYpLiXq71dGiRgOvCoEJSur41hK1Yrp9Tfs/PIkebzV+BAR9cv52+Q6ckB ioGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YkinLbJksz74I3N/rbCFRP5hJarSOux5r2+/Li87NA0=; b=DWNGkDzb2a4rZoDZn+L6OUNtzpsj/ByLZ2Ehq5G2JzIp0IkEfVexcJSd5PyxUN2CW/ YYsjp4RIWLYD293GrEgfBvFCb7mcCNoNapiKM1uY6E2iK9hAZVHv9VhRWQsS3niH13cT xgMWrwgKwi/phSGkWZ9OmhvVqf8j6KAJt2KmHSS6OftJGu4eaYOX2sEld+JxtE/fCKwz 7k0QNwzCzxuIfxXWbuV+lpl8vTEER4lw0XRBfKgujg3XnIcEKDRGmj4m17OBxUvzTbmd H7LANGEQjN68ZvQFjpLRnWe/WF8UMlyCAVy7epa85MorehfISTXhYJXRycP4XlC5GKdi 9e+w== X-Gm-Message-State: APjAAAVblYu/105uVWvTuig0CTMsbal/397GU018xQ77ecDjG6lfvHTA Do6ArJZj96nEJN/zWisGuirbt6W1YRiynpWS+7RgmhCbhvM= X-Google-Smtp-Source: APXvYqyTQH1Gf++9COw4d7XXCEEhQXPQaoWsRaYIaHGd4GPygTElMEbYYM/wR9OJgV+rnj2RLyzT82n63mBZr1h7+Rw= X-Received: by 2002:a0c:b0ef:: with SMTP id p44mr7854219qvc.27.1566138210346; Sun, 18 Aug 2019 07:23:30 -0700 (PDT) MIME-Version: 1.0 References: <20190818121741.7bd82a63@zeta.dino.sk> In-Reply-To: <20190818121741.7bd82a63@zeta.dino.sk> From: Warner Losh Date: Sun, 18 Aug 2019 08:23:19 -0600 Message-ID: Subject: Re: Zynq qspi driver https://reviews.freebsd.org/D14698 To: Milan Obuch Cc: "freebsd-arm@freebsd.org" X-Rspamd-Queue-Id: 46BK6W60ZZz4ZWT X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=cJpp5rko; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::829) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.95 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; URL_IN_SUBJECT(1.00)[reviews.freebsd.org]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arm@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[9.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.96)[ip: (-9.40), ipnet: 2607:f8b0::/32(-2.95), asn: 15169(-2.38), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Aug 2019 14:23:33 -0000 On Sun, Aug 18, 2019 at 4:18 AM Milan Obuch wrote: > Hi, > > I was able to use in subject mentioned driver on my Zybo Z7 board. I > just downloaded zy7_qspi.c file, put it in sys/arm/xilinx directory and > all other necessary patches applied per hand to 12.0-STABLE source > tree. > > I am able to read and write flash attached to qspi on my board. u-boot > uses qspi flash for environment storage so some caution should be taken > with that. > > Question: what needs to be done in order to get this driver into > official source tree? Is there any show stopper? My experience is - it > Just Works (tm). > It looks almost ready to my eye. Not sure what the hold up is. Warner